Skip to content

fix: handle illegal state exceptions in TopicMessageQuery subscription#1403

Merged
rwalworth merged 1 commit intohiero-ledger:mainfrom
oGranny:fix/1344-handle-empty-mirror-network
Apr 11, 2026
Merged

fix: handle illegal state exceptions in TopicMessageQuery subscription#1403
rwalworth merged 1 commit intohiero-ledger:mainfrom
oGranny:fix/1344-handle-empty-mirror-network

Conversation

@oGranny
Copy link
Copy Markdown
Contributor

@oGranny oGranny commented Apr 11, 2026

Description:
improves error handling in the TopicMessageQuery subscription logic, ensuring that cases where the mirror network is not configured or no mirror nodes are available are handled gracefully. It also adds a new integration test to verify this behavior.

Related issue(s):
Fixes #1344

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@oGranny oGranny requested review from a team as code owners April 11, 2026 09:45
@oGranny oGranny requested a review from gsstoykov April 11, 2026 09:45
@github-actions
Copy link
Copy Markdown

Hey @oGranny 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:


PR Checks

DCO Sign-off -- All commits have valid sign-offs. Nice work!


GPG Signature -- All commits have verified GPG signatures. Locked and loaded!


Merge Conflicts -- No merge conflicts detected. Smooth sailing!


Issue Link -- Linked to #1344 (assigned to you).


🎉 All checks passed! Your PR is ready for review. Great job!

@github-actions github-actions bot added the status: needs review The pull request is ready for maintainer review label Apr 11, 2026
rwalworth
rwalworth previously approved these changes Apr 11, 2026
Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @oGranny - the fix is clean and the logic is correct. I left one small non-blocking suggestion on the test below. Running workflows and will merge once they pass!

Signed-off-by: oGranny <ogranny.github.io@gmail.com>
@oGranny oGranny force-pushed the fix/1344-handle-empty-mirror-network branch from 730679e to 6ec76f9 Compare April 11, 2026 19:04
@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 4 complexity · 0 duplication

Metric Results
Complexity 4
Duplication 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@oGranny
Copy link
Copy Markdown
Contributor Author

oGranny commented Apr 11, 2026

Hey @rwalworth, I’ve fixed the linting issues. Let me know if everything looks good.

Copy link
Copy Markdown
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting fixes look clean - LGTM! Running the workflows and will merge once they pass!

@rwalworth rwalworth merged commit a718a39 into hiero-ledger:main Apr 11, 2026
11 checks passed
@rwalworth rwalworth removed the status: needs review The pull request is ready for maintainer review label Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Beginner]: Handle empty mirror network safely in TopicMessageQuery subscription

2 participants