fix: handle illegal state exceptions in TopicMessageQuery subscription#1403
Conversation
|
Hey @oGranny 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1344 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
Signed-off-by: oGranny <ogranny.github.io@gmail.com>
730679e to
6ec76f9
Compare
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
|
Hey @rwalworth, I’ve fixed the linting issues. Let me know if everything looks good. |
rwalworth
left a comment
There was a problem hiding this comment.
Linting fixes look clean - LGTM! Running the workflows and will merge once they pass!
|
👋 Hi @oGranny! Great work on your recent contribution! 🎉 Here are some issues you might want to explore next:
Happy coding! 🚀 |
Description:
improves error handling in the
TopicMessageQuerysubscription logic, ensuring that cases where the mirror network is not configured or no mirror nodes are available are handled gracefully. It also adds a new integration test to verify this behavior.Related issue(s):
Fixes #1344
Checklist