1617 test setup 1618 sample env file by kaldun-tech · Pull Request #1635 · hiero-ledger/hiero-sdk-go

kaldun-tech · 2026-03-07T01:06:52Z

Description:

Add TESTING.md with instructions for running unit and e2e tests
Add env.sh.sample documenting required environment variables for tests/examples. Users copy the script to env.sh, update their variables and and source it
Update README.md to reference new documentation

Related issue(s):

Fixes #1617 #1618

Notes for reviewer:

Test plan

Verify env.sh.sample can be copied to env.sh, filled in, and sourced
Verify unit test command from TESTING.md works: go test ./sdk -tags="unit" -v -timeout 9999s
Verify links in README.md resolve correctly

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

- Add TESTING.md with instructions for running unit and e2e tests - Add .env.sample documenting required environment variables - Update README.md to reference new documentation Closes hiero-ledger#1617, closes hiero-ledger#1618 Signed-off-by: kaldun-tech <tsmereka@protonmail.com>

… to network choice Signed-off-by: kaldun-tech <tsmereka@protonmail.com>

lfdt-bot · 2026-03-07T01:07:20Z

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

kaldun-tech · 2026-03-07T01:10:45Z

@0xivanov I believe this should be sufficient for issues #1617 #1618

I see failures in the unit tests and golangci-lint run in my environment that should not be related to my documentation changes.

codecov · 2026-03-11T12:52:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 177 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kaldun-tech · 2026-03-11T15:43:35Z

Would I want to update the CHANGELOG.md file here or is that only done when tagging a release?

codacy-production · 2026-03-31T13:01:45Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}

Dosik13

good work, left some comments.
Also, very sorry for the delay 😊

No, you don't need to update the changelog.

TESTING.md

.env.sample

TESTING.md

.env.sample

- Remove erroneous diff metadata line from TESTING.md - Update .env.sample to mention all supported private key formats (hex, DER-encoded, PEM-prefixed) Signed-off-by: kaldun-tech <tsmereka@protonmail.com>

Rename .env.sample to setup-env.sh.sample with export statements so users can source the file directly before running tests. - Add export statements to all environment variables - Update README.md and TESTING.md to reference new file - Add .env.sh and env.sh to .gitignore - Add note about HEDERA_NETWORK taking precedence over CONFIG_FILE Signed-off-by: kaldun-tech <tsmereka@protonmail.com>

.env.sample

…ILE precedence - Rename setup-env.sh.sample to env.sh.sample for simplicity (env.sh already in .gitignore) - Clarify that CONFIG_FILE is only used when OPERATOR_ID, OPERATOR_KEY, and HEDERA_NETWORK are all unset - Update references in README.md and TESTING.md Signed-off-by: kaldun-tech <tsmereka@protonmail.com>

.env is the standard convention for environment variable files and will be compatible with godotenv in the future. Updated all documentation references and cleaned up .gitignore. Signed-off-by: kaldun-tech <tsmereka@protonmail.com>

Dosik13

left final comments - you an also think of a way to make the user understand that once he did the source .env the values are exported to the terminal and dont have to do it every time (you can also leave it, i don't think it is a big problem). And I think we will be ready to merge it

TESTING.md

Remove trailing newline Co-authored-by: Dosi Kolev <104355829+Dosik13@users.noreply.github.com> Signed-off-by: Taras <tsmereka@protonmail.com>

Clarified language of copying .env.sample to .env Co-authored-by: Dosi Kolev <104355829+Dosik13@users.noreply.github.com> Signed-off-by: Taras <tsmereka@protonmail.com>

Added HEDERA_NETWORK variable export recommendation Co-authored-by: Dosi Kolev <104355829+Dosik13@users.noreply.github.com> Signed-off-by: Taras <tsmereka@protonmail.com>

kaldun-tech · 2026-04-10T04:55:38Z

Yes I agree those are good changes. Considered how to communicate that they don't have to source .env every time in the terminal. It shouldn't come up unless they are making changes to the file.

kaldun-tech added 2 commits March 6, 2026 17:47

Correctly added TESTING.md and update language of .env.sample related…

f3009f0

… to network choice Signed-off-by: kaldun-tech <tsmereka@protonmail.com>

kaldun-tech requested review from a team as code owners March 7, 2026 01:06

kaldun-tech requested review from 0xivanov, MilanWR and leninmehedy March 7, 2026 01:06

Merge branch 'main' into 1617_TestSetup_1618_SampleEnvFile

8f6112d

Merge branch 'main' into 1617_TestSetup_1618_SampleEnvFile

56115ca

Dosik13 reviewed Mar 31, 2026

View reviewed changes

TESTING.md Outdated Show resolved Hide resolved

.env.sample Outdated Show resolved Hide resolved

.env.sample Show resolved Hide resolved

TESTING.md Show resolved Hide resolved

TESTING.md Show resolved Hide resolved

.env.sample Outdated Show resolved Hide resolved

kaldun-tech added 2 commits March 31, 2026 20:39

fix: address PR review comments

cd33ed9

- Remove erroneous diff metadata line from TESTING.md - Update .env.sample to mention all supported private key formats (hex, DER-encoded, PEM-prefixed) Signed-off-by: kaldun-tech <tsmereka@protonmail.com>

Dosik13 reviewed Apr 2, 2026

View reviewed changes

.env.sample Show resolved Hide resolved

kaldun-tech added 2 commits April 2, 2026 11:43

Dosik13 mentioned this pull request Apr 8, 2026

fix: Corrupted isApproved flag #1651

Closed

2 tasks

Dosik13 reviewed Apr 8, 2026

View reviewed changes

TESTING.md Outdated Show resolved Hide resolved

TESTING.md Outdated Show resolved Hide resolved

TESTING.md Outdated Show resolved Hide resolved

kaldun-tech and others added 3 commits April 9, 2026 22:50

Update TESTING.md

cb453a9

Remove trailing newline Co-authored-by: Dosi Kolev <104355829+Dosik13@users.noreply.github.com> Signed-off-by: Taras <tsmereka@protonmail.com>

Update TESTING.md

ae40178

Clarified language of copying .env.sample to .env Co-authored-by: Dosi Kolev <104355829+Dosik13@users.noreply.github.com> Signed-off-by: Taras <tsmereka@protonmail.com>

Update TESTING.md

e583291

Added HEDERA_NETWORK variable export recommendation Co-authored-by: Dosi Kolev <104355829+Dosik13@users.noreply.github.com> Signed-off-by: Taras <tsmereka@protonmail.com>

Conversation

kaldun-tech commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test plan

Uh oh!

lfdt-bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Snyk checks have passed. No issues have been found so far.

Uh oh!

kaldun-tech commented Mar 7, 2026

Uh oh!

codecov bot commented Mar 11, 2026

Codecov Report

Uh oh!

kaldun-tech commented Mar 11, 2026

Uh oh!

codacy-production bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Up to standards ✅

Uh oh!

Dosik13 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dosik13 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kaldun-tech commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kaldun-tech commented Mar 7, 2026 •

edited

Loading

lfdt-bot commented Mar 7, 2026 •

edited

Loading

codacy-production bot commented Mar 31, 2026 •

edited

Loading

Dosik13 left a comment •

edited

Loading