fix: Prevent proto package recompiling on every build#941
Open
tr11 wants to merge 10 commits intohiero-ledger:mainfrom
Open
fix: Prevent proto package recompiling on every build#941tr11 wants to merge 10 commits intohiero-ledger:mainfrom
tr11 wants to merge 10 commits intohiero-ledger:mainfrom
Conversation
Contributor
|
@tr11 Thanks for the contribution! DCO checks will fail when commits are not signed. Take a look at https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key |
tr11
force-pushed
the
fix-proto-recompiling
branch
2 times, most recently
from
d9d6ce1 to
13639aa
Compare
Signed-off-by: Tiago Requeijo <tiago.requeijo.dev@gmail.com>
Signed-off-by: Tiago Requeijo <tiago.requeijo.dev@gmail.com>
tr11
force-pushed
the
fix-proto-recompiling
branch
from
13639aa to
6f033d5
Compare
Signed-off-by: Tiago Requeijo <tiago.requeijo.dev@gmail.com>
tr11
force-pushed
the
fix-proto-recompiling
branch
from
fedcef3 to
1884cee
Compare
Contributor
Contributor
tr11
changed the title
Signed-off-by: Tiago Requeijo <tiago.requeijo.dev@gmail.com>
…t into fix-proto-recompiling
Author
|
Formatting updated and rebased to the 0.40 version. |
tr11
force-pushed
the
fix-proto-recompiling
branch
from
9956ac7 to
7600f80
Compare
tr11
force-pushed
the
fix-proto-recompiling
branch
from
7600f80 to
c35a582
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Prevent the
hederaandhedera-protopackages from recompiling on every built of dependent crates.Related issue(s): None
Fixes #
Currently the proto package will trigger a recompilation of both
hederaandhedera-protopackages even if nothing changed in the protobufs folder. This PR changes theemit_rerun_if_changedbehavior before compiling the modified proto files from services folder to ensure reruns only trigger when there are modifications.Notes for reviewer:
Test by compiling twice any crate dependent on this package.
Checklist