ci: add CodeQL Advanced security scanning workflow#387
ci: add CodeQL Advanced security scanning workflow#387cheese-cakee wants to merge 1 commit intohiero-ledger:mainfrom
Conversation
✅ Deploy Preview for hiero-open-source ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 49 minutes and 41 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request adds a CodeQL Advanced workflow to automatically scan GitHub Actions workflows and JavaScript/TypeScript code for security vulnerabilities. The workflow triggers on main branch pushes, pull requests, and daily schedules, with documentation added explaining the configuration and its impact on contributor expectations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📋 Issue PlannerBuilt with CodeRabbit's Coding Plans for faster development and fewer bugs. View plan used: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/codeql.yml (1)
5-14: Addworkflow_dispatchtrigger for on-demand CodeQL scans.Other workflows in this repository (e.g.,
ci.yml) already include this trigger. It's useful for incident response or quick validation after query/config tuning without waiting for scheduled runs or pushes.🔧 Suggested update
on: push: branches: ["main"] pull_request: branches: ["main"] paths-ignore: - "**/*.md" schedule: - cron: "28 23 * * *" + workflow_dispatch:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/codeql.yml around lines 5 - 14, Update the CodeQL workflow trigger block to allow manual runs by adding the workflow_dispatch event alongside push, pull_request, and schedule; modify the top-level on: stanza in .github/workflows/codeql.yml (the existing on: block) to include workflow_dispatch so maintainers can trigger CodeQL scans on demand.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/codeql.yml:
- Around line 5-14: Update the CodeQL workflow trigger block to allow manual
runs by adding the workflow_dispatch event alongside push, pull_request, and
schedule; modify the top-level on: stanza in .github/workflows/codeql.yml (the
existing on: block) to include workflow_dispatch so maintainers can trigger
CodeQL scans on demand.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7f0fd07b-7948-4155-981d-cef614006524
📒 Files selected for processing (2)
.github/workflows/codeql.ymldocs/07-github-automation.md
Adds security scanning via GitHub CodeQL to detect vulnerabilities in JavaScript/TypeScript source and GitHub Actions workflows. - Analyzes javascript-typescript and actions with build-mode: none - Uses security-extended query suite for comprehensive coverage - SHA-pinned actions following existing repo conventions - Daily scheduled run at 23:28 UTC plus push/PR triggers - paths-ignore on PRs to skip markdown-only changes - Updated docs/07-github-automation.md Closes hiero-ledger#386 Signed-off-by: cheese-cakee <farzanaman99@gmail.com>
36fcb44 to
63189f4
Compare
|
The CodeQL check failures are expected until the default CodeQL setup is disabled in repo Settings > Code security. I think someone with permission needs to switch from 'Default' to 'Advanced' (or disable it) since a custom codeql.yml now handles analysis.thankyou. |
Description
Adds security scanning via GitHub CodeQL to detect vulnerabilities in JavaScript/TypeScript source and GitHub Actions workflows.
Changes Made
.github/workflows/codeql.yml— CodeQL Advanced workflow with matrix strategy analyzingjavascript-typescriptandactionslanguagesdocs/07-github-automation.md— documented the new workflowRelated Issues
Closes #386
Checklist
Summary by CodeRabbit
Chores
Documentation