fix(tooling): correct github user resolution in dco script#127
Open
aashu2006 wants to merge 1 commit intohiero-ledger:mainfrom
Open
fix(tooling): correct github user resolution in dco script#127aashu2006 wants to merge 1 commit intohiero-ledger:mainfrom
aashu2006 wants to merge 1 commit intohiero-ledger:mainfrom
Conversation
Signed-off-by: aashu2006 <akshatp439@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
Author
|
Hi @exploreriii ! Can you please look into this PR, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix incorrect GitHub username resolution logic in DCO check script.
The
dco.pyscript had a logic error on line 117 whereget_github_username_by_email()was being called instead ofget_github_email_by_username(), causing the script to fail when resolving user information from GitHub API.Changes:
Related issue(s): N/A (Discovered during code review)
Checklist