Open
Conversation
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
… formula update branch (#32) * Initial plan Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> * fix: replace peter-evans/create-pull-request with gh pr create to prevent branch force-push Co-authored-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com> Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> --------- Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com> Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…removed during brew install (#35) * chore: homebrew release solo 0.62.0 and 0.63.0 (#33) Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> * Initial plan Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> * fix: fail fast with clear instructions when brew install solo cannot remove stale bin/solo - Change opoo (warning) to odie (fatal error) when bin/solo cannot be removed due to permission issues, so the install fails fast with clear actionable instructions instead of continuing for ~40s and then failing at the brew link step with a confusing error message. - Extract the brew install command to a variable (brew_install_cmd) derived from the formula's own tap/name to avoid string duplication. - Add new standalone workflow test-brew-install-version.yml that accepts a solo version string and tests brew installation on GitHub runner. - Update test comment in test-brew-install.yml to reflect new fail-fast behavior for the stale-brew-bin-permission scenario. Co-authored-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com> Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> --------- Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> Co-authored-by: JeffreyDallas <39912573+JeffreyDallas@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Jeffrey Tang <jeffrey@swirldslabs.com> Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Hashgraph Eng Automation <eng-automation@hashgraph.com> Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
…mp-solo-homebrew-0.64.0 Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com> # Conflicts: # Formula/solo.rb
…mp-solo-homebrew-0.64.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Give better user prompt when could not delete previous installed npm installed symbol link
Notes for reviewer:
Checklist