This repository was archived by the owner on May 23, 2024. It is now read-only.
Use the FQCN throughout the whole project#13
Merged
tobiashuste merged 1 commit intohifis-net:mainfrom Apr 12, 2022
Merged
Conversation
christianhueserhzdr
suggested changes
Apr 11, 2022
Member
christianhueserhzdr
left a comment
christianhueserhzdr
left a comment
There was a problem hiding this comment.
Dear Tobias @tobiashuste, I spotted one inconsistency regarding make calls in the role tasks. All else is fine.
christianhueserhzdr
approved these changes
Apr 11, 2022
Member
christianhueserhzdr
left a comment
christianhueserhzdr
left a comment
There was a problem hiding this comment.
Dear Tobias @tobiashuste, thanks for fixing the FQCN of the respective make call. I approve and merge this PR now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12
Required for #7