Add initial bus stop grouping feature#24
Closed
kaon wants to merge 5 commits intohkbus:masterfrom
kaon:group-bus
Closed
Add initial bus stop grouping feature#24kaon wants to merge 5 commits intohkbus:masterfrom kaon:group-bus
kaon wants to merge 5 commits intohkbus:masterfrom
kaon:group-bus
Conversation
added 5 commits
September 20, 2024 09:22
rtau
reviewed
Sep 22, 2024
| visited = set() | ||
| group_id = 1 | ||
|
|
||
| print(len(bus_stops)) |
Contributor
There was a problem hiding this comment.
It is observed that from start of the script to this print line, it took roughly 3 minutes to run on GitHub actions. I would suspect the KDTree is taking most of the time
Author
|
Closed in favour of #26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments welcome for improvement before actual deployment