Skip to content

package infrastructure updates#29

Merged
holub008 merged 13 commits intoholub008:masterfrom
topepo:upkeep-2025
Nov 20, 2025
Merged

package infrastructure updates#29
holub008 merged 13 commits intoholub008:masterfrom
topepo:upkeep-2025

Conversation

@topepo
Copy link
Copy Markdown
Contributor

@topepo topepo commented Nov 18, 2025

  • air was used to format code
  • R dependency is not >= 4.1.0
  • Transition to base R pipe
  • Transition errors and warnings to use the cli package
  • update GHA
  • Move (mostly) away from using .data$ prefixes in dplyr selections
  • Declare a many-to-many join
  • Reorganize tests a bit; use a helper file, 3rd edition of testthat, etc
  • Declare some variables used in tidyselect to avoid global variable check false positives

Comment thread R/glmnot.R
Comment thread R/hyperrectangle_overlap.R Outdated
Comment thread R/utils.R
Comment thread R/xrf.R
Comment thread tests/testthat/test_deoverlap.R
Comment thread tests/testthat/test_model.R Outdated
@topepo
Copy link
Copy Markdown
Contributor Author

topepo commented Nov 18, 2025

A little more to do. I made a draft PR just to see if the new GHAs work well.

@topepo topepo marked this pull request as ready for review November 19, 2025 16:34
@topepo
Copy link
Copy Markdown
Contributor Author

topepo commented Nov 19, 2025

Initial changes for #28

@holub008 it is ready for review!

Copy link
Copy Markdown
Owner

@holub008 holub008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the modernization and love the formatting consistency

Comment thread R/hyperrectangle_overlap.R Outdated
Comment thread R/utils.R
@topepo
Copy link
Copy Markdown
Contributor Author

topepo commented Nov 20, 2025

I think it's ready to merge. Thanks!

Comment thread R/hyperrectangle_overlap.R Outdated
@holub008 holub008 merged commit 32fd812 into holub008:master Nov 20, 2025
10 checks passed
@holub008
Copy link
Copy Markdown
Owner

Thanks Max, you're great!

@holub008 holub008 mentioned this pull request Nov 20, 2025
@topepo topepo deleted the upkeep-2025 branch November 20, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants