Replace whois with python-whois

[Misiu]

Breaking change

There can be some because the used library is returning data in a different format

Proposed change

Replacement of unmaintained whois upstream library with a maintained one.
With this change getting expiration dates for .pl domains finally works.

This is a continuation of #117749, but with addressed comments

The tests are still missing, because I'd like to get some initial feedback from the integration owner if this is the right direction and how we can proceed with this, to fix the missing expiration date for some domains

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Whois integration issues #117805
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @frenck, mind taking a look at this pull request as it has been labeled with an integration (whois) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of whois can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign whois Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[frenck]

I am against moving to this package. It has caused lots of issue, we migrated away from it.

It lacks typing and is missing error handling.

My comments from the original PR thus remains.

../Frenck

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[Misiu]

Thank you for the reply.

The current integration does not work for the domains I own and manage. This was my motivation: to fix the current integration and have working expiration date sensors.
I was searching for other packages, but one that is also popular has memory issues.
I can replace the library with another, but I don't know which one is acceptable, so I'm open to suggestions.
According to https://pypi.org/project/whois/, the currently used package is not supported and, as mentioned, is not working correctly.

[joostlek]

The pypi you linked does link to another package, maybe that works?

[Misiu]

@joostlek that's the other package aixmentioned, the one with the memory issue - mboot-github/WhoisDomain#30

[Misiu]

The author of the package has added types to the library - richardpenman/whois@a715774
Feedback about this change and what else should be added to move this forward is welcome

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!