Verification Request: @boozilla/homebridge-shome

[boozilla]

Plugin Name

@boozilla/homebridge-shome

Link To GitHub Repo

https://github.com/boozilla/homebridge-shome

Plugin Icon (Optional)

The plugin does not offer the same nor less functionality than that of any existing verified plugin.

🟠 No (please explain in the more information box at the end)

The plugin successfully installs and does not start unless it is configured.

🟢 Yes

The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.

🟢 Yes

The plugin does not contain any analytics or calls that enable you to track the user.

🟢 Yes

If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.

🟢 Yes

The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.

🟢 Yes

More Information

The existing @bawappie/homebridge-shome plugin includes air conditioner control functionality but due to personal hardware issues I was unable to test the air conditioner. Therefore my plugin does not include air conditioner control. Furthermore the existing bawappie plugin is currently not being maintained leading to compatibility issues with the latest version of Homebridge which I have improved. Instead my plugin now includes boiler control functionality.

[github-actions]

🔴 Failed Checks

• Config Schema JSON: schema is invalid - required should not be a boolean property on individual fields. In JSON Schema, required must be an array at the object level listing required property names. Remove "required": true/false from individual properties and use "required": ["property1", "property2"] at the object level instead.
• Config Schema JSON: does not contain a valid pluginAlias
• Config Schema JSON: the pluginType is not set to 'platform'
• GitHub Repo: should contain releases

🟢 Passed Checks

• Installation: successfully installed
• Package JSON: homepage exists
• Package JSON: bugs.url exists and seems a valid URL
• Package JSON: keywords exist and contain 'homebridge-plugin'
• Package JSON: 'preinstall' in scripts is not present
• Package JSON: 'install' in scripts is not present
• Package JSON: 'postinstall' in scripts is not present
• Package JSON: engines.node property is compatible with Node 20
• Package JSON: engines.node property is compatible with Node 22
• Package JSON: engines.homebridge property is compatible with Homebridge 1.11.0
• Package JSON: initializer function found
• NPM Package: has not been deprecated
• GitHub Repo: version in package.json (v1.0.1) matches NPM version (v1.0.1)
• Config Schema JSON: exists and is valid JSON
• Config Schema JSON: contains a name schema property
• Dependencies: homebridge was not installed as a dependency
• Dependencies: hap-nodejs was not installed as a dependency
• Security: no known vulnerabilities in dependencies
• Security: no unsafe code patterns detected
• Security: no privilege escalation attempts detected
• GitHub Repo: repository is public
• GitHub Repo: repository is not archived
• GitHub Repo: issues are enabled

ℹ️ Check Details

• These checks were run against v1.0.1 of the plugin.
• Link to the run workflow: visit →.

📋 Next Steps

• Please action these failures and then comment /check to run the checks again.
• If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.
• Remember this is an automatic script: if you think something has been marked as a failure in error, let us know with a reply.
• Feel free to ask any questions you have by replying to this issue.

[boozilla]

/check

[github-actions]

🟢 Passed Checks

• Installation: successfully installed
• Package JSON: homepage exists
• Package JSON: bugs.url exists and seems a valid URL
• Package JSON: keywords exist and contain 'homebridge-plugin'
• Package JSON: 'preinstall' in scripts is not present
• Package JSON: 'install' in scripts is not present
• Package JSON: 'postinstall' in scripts is not present
• Package JSON: engines.node property is compatible with Node 20
• Package JSON: engines.node property is compatible with Node 22
• Package JSON: engines.homebridge property is compatible with Homebridge 1.11.0
• Package JSON: initializer function found
• NPM Package: has not been deprecated
• GitHub Repo: version in package.json (v1.0.2) matches NPM version (v1.0.2)
• Config Schema JSON: exists and is valid JSON
• Config Schema JSON: contains valid JSON Schema
• Config Schema JSON: schema has valid type property
• Config Schema JSON: schema has valid properties for object type
• Config Schema JSON: contains a valid pluginAlias
• Config Schema JSON: the pluginType is set to 'platform'
• Config Schema JSON: contains a name schema property
• Dependencies: homebridge was not installed as a dependency
• Dependencies: hap-nodejs was not installed as a dependency
• Security: no known vulnerabilities in dependencies
• Security: no unsafe code patterns detected
• Security: no privilege escalation attempts detected
• Runtime: homebridge installed successfully
• Runtime: no config - homebridge should start without plugin configuration and plugin should not load
• Runtime: platform only - plugin should start with just platform property
• Runtime: minimal required - plugin should start with minimal required configuration
• Runtime: full config - plugin should start with comprehensive configuration
• Runtime: network resilience - plugin should handle network failures without crashing
• GitHub Repo: repository is public
• GitHub Repo: repository is not archived
• GitHub Repo: issues are enabled
• GitHub Repo: contains releases

ℹ️ Check Details

• These checks were run against v1.0.2 of the plugin.
• Link to the run workflow: visit →.
• External HTTP requests detected:
  • 📡 https://shome-api.samsung-ihp.com/v18/users/login
    Methods: PUT | Count: 4 | Scenarios: full config, minimal required, network resilience, platform only

📋 Next Steps

All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

[boozilla]

/check

[github-actions]

🔴 Failed Checks

Runtime Issues:

• ⚠️ Plugin crashes when started with the following configuration:

  {
    "platform": "sHome"
  }

  Error:

  expected startup but failed - Plugin initialization error detected
  

  This needs to be fixed so that the plugin does not send Homebridge into a crash-restart loop. The plugin could:

  • Handle missing required configuration gracefully with proper error messages
  • Provide sensible defaults for missing values
  • Validate configuration during startup and log helpful warnings

• ⚠️ Plugin crashes when network requests fail:

  Test scenario: Network resilience test with simulated HTTP failures

  Configuration used:

  {
    "platform": "sHome",
    "name": "sHome",
    "username": "testuser@example.com",
    "password": "testpassword",
    "deviceId": "test-value"
  }

  Error:

  expected startup but failed - Plugin initialization error detected
  

  This test simulates network failures to verify the plugin handles HTTP errors gracefully. The plugin should:

  • Implement proper error handling for all HTTP requests
  • Use try-catch blocks or .catch() handlers for promises
  • Provide fallback behavior when external services are unavailable
  • Log errors appropriately without crashing Homebridge
  • Consider implementing retry logic with exponential backoff

🟢 Passed Checks

• Installation: successfully installed
• Package JSON: homepage exists
• Package JSON: bugs.url exists and seems a valid URL
• Package JSON: keywords exist and contain 'homebridge-plugin'
• Package JSON: 'preinstall' in scripts is not present
• Package JSON: 'install' in scripts is not present
• Package JSON: 'postinstall' in scripts is not present
• Package JSON: engines.node property is compatible with Node 20
• Package JSON: engines.node property is compatible with Node 22
• Package JSON: engines.homebridge property is compatible with Homebridge 1.11.0
• Package JSON: initializer function found
• NPM Package: has not been deprecated
• GitHub Repo: version in package.json (v1.0.6) matches NPM version (v1.0.6)
• Config Schema JSON: exists and is valid JSON
• Config Schema JSON: contains valid JSON Schema
• Config Schema JSON: schema has valid type property
• Config Schema JSON: schema has valid properties for object type
• Config Schema JSON: contains a valid pluginAlias
• Config Schema JSON: the pluginType is set to 'platform'
• Config Schema JSON: contains a name schema property
• Dependencies: homebridge was not installed as a dependency
• Dependencies: hap-nodejs was not installed as a dependency
• Security: no known vulnerabilities in dependencies
• Security: no unsafe code patterns detected
• Security: no privilege escalation attempts detected
• Runtime: homebridge installed successfully
• Runtime: no config - homebridge should start without plugin configuration and plugin should not load
• Runtime: minimal required - plugin should start with minimal required configuration
• Runtime: full config - plugin should start with comprehensive configuration
• GitHub Repo: repository is public
• GitHub Repo: repository is not archived
• GitHub Repo: issues are enabled
• GitHub Repo: contains releases

ℹ️ Check Details

• These checks were run against v1.0.6 of the plugin.
• Link to the run workflow: visit →.
• External HTTP requests detected:
  • 📡 https://shome-api.samsung-ihp.com/v18/users/login
    Methods: PUT | Count: 10 | Scenarios: full config, minimal required, network resilience, platform only

📋 Next Steps

• Please action these failures and then comment /check to run the checks again.
• If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.
• Remember this is an automatic script: if you think something has been marked as a failure in error, let us know with a reply.
• Feel free to ask any questions you have by replying to this issue.