feat(types): Support types until 10 handlers#1735
Merged
yusukebe merged 5 commits intohonojs:nextfrom Nov 28, 2023
Merged
Conversation
Member
|
Hi @gabrielDonnantuoni ! Thank you for this PR. As you mentioned, while it may not be the best solution, it seems to be the only way available. It looks good, and I'll review the details later. |
yusukebe
reviewed
Nov 28, 2023
Contributor
Author
|
|
Member
|
Great work! Since this is a new feature, I'll merge it into the "next" branch for the upcoming minor release Thank you very much. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle until 10 handlers on
app.method([path], ...handlers)by simple adding more overloads.This is not optimal by far. I'm compromised to find a better and beautiful solution, but until then I think this will cover more use cases, like I'm personally facing now.
Author should do the followings, if applicable
yarn denoifyto generate files for Deno