fix(types): replace Hono with HonoBase to get better consistency of types

[m-shaka]

The author should do the following, if applicable

• Add tests
• Run tests
• bun run format:fix && bun run lint:fix to format the code
• Add TSDoc/JSDoc to document the code

I don't understand the cause well, but this change resolved #3485 (comment)

Also, I removed mutual dependency between Hono and HonoBase:

graph TD;
    HonoBase-->HandlerInterface;
    HandlerInterface-->Hono;
    Hono-->HonoBase;

Loading

There are subclasses of HonoBase other than Hono, so return types of HandlerInterface should not be Hono.

[yusukebe]

@m-shaka Thanks! Great!

What I find a little curious is that the type of the value returned by app.get() is not HonoBase, but Hono. This is ideal behavior, but I couldn't figure out why this is the following.

[yusukebe]

@m-shaka

The behavior I commented is ideal, so if it is the correct behavior you expected, let's go with it.

[m-shaka]

What I find a little curious is that the type of the value returned by app.get() is not HonoBase, but Hono.

I guess this is because HonoBase is named as Hono when it's defined. If you rename HonoBase Hono, you'll see HonoBase there

hono/src/hono-base.ts

Line 102 in e7732a5

class Hono<E extends Env = Env, S extends Schema = {}, BasePath extends string = '/'> {

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (0e0b473) to head (d36134e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #3580    +/-   ##
========================================
  Coverage   94.71%   94.71%            
========================================
  Files         158      158            
  Lines        9535     9535            
  Branches     2774     2886   +112     
========================================
  Hits         9031     9031            
  Misses        504      504            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yusukebe]

LGTM!

[yusukebe]

@m-shaka Thanks! Let's go with this.