feat(parseResponse): set DetailedError.name (+ error tests)#4344
Merged
yusukebe merged 2 commits intohonojs:mainfrom Aug 8, 2025
Merged
feat(parseResponse): set DetailedError.name (+ error tests)#4344yusukebe merged 2 commits intohonojs:mainfrom
DetailedError.name (+ error tests)#4344yusukebe merged 2 commits intohonojs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4344 +/- ##
========================================
Coverage 91.41% 91.41%
========================================
Files 172 172
Lines 10900 10901 +1
Branches 3268 3163 -105
========================================
+ Hits 9964 9965 +1
Misses 935 935
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DetailedError.name (+ error tests)DetailedError.name (+ error tests)
Member
|
Ah, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply set the
.namefor theDetailedErrorclass, which is a good pratice, so user is able to do a fast equality check in code / search for the error in log.I forgot to add it previously and just hit a case where I need it because I have
DetailedErrorclasses coming from multiple source andinstanceofis a bit wonky.I also added tests for cases where error is thrown.
Theoretically "breaking", but should be safe to include in next patch.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code