Skip to content

refactor(hono-base): add type annotations#4591

Merged
yusukebe merged 1 commit intomainfrom
refactor/hono-base-type-annotations
Dec 25, 2025
Merged

refactor(hono-base): add type annotations#4591
yusukebe merged 1 commit intomainfrom
refactor/hono-base-type-annotations

Conversation

@yusukebe
Copy link
Copy Markdown
Member

@yusukebe yusukebe commented Dec 25, 2025

Added the missing type annotations. This change improves the type performance slightly.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@github-actions
Copy link
Copy Markdown

Bundle size check

main (d454b31) #4591 (6b77f59) +/-
Bundle Size (B) 18,377B 18,377B 0B
Bundle Size (KB) 17.95K 17.95K 0K

Compiler Diagnostics (tsc)

main (d454b31) #4591 (6b77f59) +/-
Files 303 303 0
Lines 141,168 141,168 0
Identifiers 128,951 128,955 4
Symbols 269,872 269,855 -17
Types 206,566 206,545 -21
Instantiations 666,443 666,425 -18
Memory used 345,467K 358,440K 12,973K
I/O read 0.02s 0.03s 0.01s
I/O write 0s 0s 0s
Parse time 0.73s 0.84s 0.11s
Bind time 0.29s 0.32s 0.03s
Check time 2.55s 2.6s 0.05s
Emit time 0s 0s 0s
Total time 3.57s 3.77s 0.2s

Compiler Diagnostics (typescript-go)

main (d454b31) #4591 (6b77f59) +/-
Files 303 303 0
Lines 141,170 141,170 0
Identifiers 128,914 128,918 4
Symbols 391,095 388,312 -2,783
Types 378,717 378,675 -42
Instantiations 1,078,045 1,078,004 -41
Memory used 257,782K 257,360K -422K
Memory allocs 2,721,128 2,720,895 -233
Config time 0.001s 0.001s 0s
Parse time 0.092s 0.099s 0.007s
Bind time 0.019s 0.022s 0.003s
Check time 0.638s 0.65s 0.012s
Emit time 0s 0s 0s
Total time 0.821s 0.832s 0.011s

Reported by octocov

@github-actions
Copy link
Copy Markdown

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 36,860.18 49,723.52 32,800.40 28,056.63
hono (current) bun 36,791.71 49,674.06 32,624.20 28,076.87
Change -0.19% -0.10% -0.54% +0.07%

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.56%. Comparing base (d454b31) to head (ca536b8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4591   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         173      173           
  Lines       11256    11256           
  Branches     3266     3266           
=======================================
  Hits        10307    10307           
  Misses        948      948           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe merged commit d8ea652 into main Dec 25, 2025
20 checks passed
@yusukebe yusukebe deleted the refactor/hono-base-type-annotations branch December 25, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant