feat: add 'methodNotAllowed' handler for '405 Method Not Allowed' responses#4637
Open
silvioprog wants to merge 1 commit intohonojs:mainfrom
Open
feat: add 'methodNotAllowed' handler for '405 Method Not Allowed' responses#4637silvioprog wants to merge 1 commit intohonojs:mainfrom
silvioprog wants to merge 1 commit intohonojs:mainfrom
Conversation
749d7a1 to
7143c4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in
app.methodNotAllowed()handler that returns405 Method Not Allowedresponses when a path exists but the HTTP method is not supported. This improves HTTP semantics by properly distinguishing between routes that don't exist (404) and routes that exist but don't support the requested method (405).Changes
MethodNotAllowedHandlerandMethodNotAllowedResponsetypesmethodNotAllowed()method toHonoBaseclass#findAllowedMethods()helper to detect allowed methods for a path#dispatch()to check for method not allowed when no route matchesBehavior
Allowheader listing permitted methodsExample Usage
Testing
bun run test)bun run format:fix)bun run lint:fix)Related
Closes #4633