feat(route): add handlerPath helper to get actual route handler path#4825
Open
GourangaDasSamrat wants to merge 1 commit intohonojs:mainfrom
Open
feat(route): add handlerPath helper to get actual route handler path#4825GourangaDasSamrat wants to merge 1 commit intohonojs:mainfrom
handlerPath helper to get actual route handler path#4825GourangaDasSamrat wants to merge 1 commit intohonojs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the codeAdds a new
handlerPath(c)helper tohono/routethat returns the path of the actual route handler, unaffected by middleware registration order.Problem:
routePath(c, -1)breaks when middleware is registered after a route handler. Because Hono matches all routes up-front, the last entry inmatchedRoutesbecomes the trailing middleware (/*), not the actual handler.Fix:
handlerPath(c)finds the first matched route whosemethodis notALL(i.e. not registered viaapp.use()), giving the correct handler path every time.No breaking changes — all existing helpers are unchanged.
Closes #4609