fix(cache): log "caches is not defined" only once#4871
fix(cache): log "caches is not defined" only once#4871yuintei wants to merge 1 commit intohonojs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4871 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 177 177
Lines 11797 11801 +4
Branches 3515 3514 -1
=======================================
+ Hits 10959 10963 +4
Misses 837 837
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @yuintei This PR is not bad. BUT, the |
|
Thank you for the response and repro! I considered that declaring the variable with |
|
@yusukebe Opt-in would be more convenient, but I understand it needs to be opt-out for backward compatibility. Thank you for working on this! Closing this PR. I can open a docs PR on honojs/website once this is merged. |
The log is repeated for every
cache()call whenglobalThis.cachesis not available. This PR ensures the message is logged only once.The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code