chore: remove unused devcontainer and gitpod configs#5029
Merged
Conversation
HTTP Performance Benchmark
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5029 +/- ##
=======================================
Coverage 79.01% 79.01%
=======================================
Files 154 154
Lines 10578 10578
Branches 2215 2215
=======================================
Hits 8358 8358
Misses 2220 2220 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I remove two things:
.gitpod.yml- Anyone does not use this now..devcontainer- I don't know if there is someone to use this. But keeping this has a small risk of attacks. It will be a rare case, but if an attacker adds malicious code into the container and it fires on the maintainer's machine, it will be bad.And this is based on the policy - less is safe. As long as nothing is added, the project will be safer against supply chain attacks.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code