fix(docs): modify import statement to type-only imports explicitly#622
Merged
yusukebe merged 1 commit intohonojs:mainfrom Mar 26, 2025
Enchan1207:Enchan1207-patch-1
Merged
fix(docs): modify import statement to type-only imports explicitly#622yusukebe merged 1 commit intohonojs:mainfrom Enchan1207:Enchan1207-patch-1
yusukebe merged 1 commit intohonojs:mainfrom
Enchan1207:Enchan1207-patch-1
Conversation
Member
|
Thanks! It should only import the types. I'll merge this. |
codeOwlAI
pushed a commit
to codeOwlAI/website
that referenced
this pull request
Jun 29, 2025
upgrade from v1.9 to v1.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Modified
importto Type-Only Imports explicitly.details
In most cases, its difference is not a problem.
conditions that cause problems
If compiler option
verbatimModuleSyntaxis enabled, type import must be written as follows:However, in pattern C, server-side code may be mixed into client-side .
why this happen
It is caused by rewriting rule of TypeScript.
The statement
import { type AppType } from '@/module'is rewritten intoimport {} from '@/module'.It means
@/modulewill still be imported as a value after compilation.I created the repository (Enchan1207/hono_rpc_import_style_differences) for reproducing its behavior.
The option
verbatimModuleSyntaxis not enabled as default, so it might be nitpick.