Fix for Issue #684 : Locked flash-attn version to prevent ABI mismatch#686
Open
alexjstephenson wants to merge 3 commits intohuggingface:mainfrom
Open
Fix for Issue #684 : Locked flash-attn version to prevent ABI mismatch#686alexjstephenson wants to merge 3 commits intohuggingface:mainfrom
alexjstephenson wants to merge 3 commits intohuggingface:mainfrom
Conversation
Updated ReadME to correct the flash-attn==2.7.4.post1 in order to prevent ABI mismatches with new flash-attn versions.
wanted to make it look nicer.
This version utilizes flash-attn==2.7.4.post1 to prevent ABI mismatches with newer commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code would automatically install latest flash-attn version, newer versions have a different ABI which is incompatible with torch 2.6.0, causing a MBI mismatch and binary issues. This fix proposes fixing flash-attn to a known working version to prevent future issues with dependency updates. Updates readme to explain to the user, as well as the makefile.
I compiled and ran successfully on this version.
Link to issue: #684