Skip to content

refactor: remove unused method receiver#213

Merged
hugoh merged 2 commits intomainfrom
deepsource-autofix-0ea61d13
Apr 18, 2026
Merged

refactor: remove unused method receiver#213
hugoh merged 2 commits intomainfrom
deepsource-autofix-0ea61d13

Conversation

@deepsource-autofix
Copy link
Copy Markdown
Contributor

This PR refactors the mockSpinner methods to eliminate unused receivers and clean up indentation.

  • Unused method receiver: The mockSpinner methods Fail, Success, and Stop originally declared a named receiver (m) that was never used. The patch replaces these named receivers with unnamed pointer receivers to adhere to Go best practices and remove compiler warnings. Additionally, the indentation of the Stop method’s return statement was standardized for consistency.

This Autofix was generated by AI. Please review the change before merging.

This PR refactors the mockSpinner methods to eliminate unused receivers and clean up indentation.
- Unused method receiver: The mockSpinner methods Fail, Success, and Stop originally declared a named receiver (m) that was never used. The patch replaces these named receivers with unnamed pointer receivers to adhere to Go best practices and remove compiler warnings. Additionally, the indentation of the Stop method’s return statement was standardized for consistency.

> This Autofix was generated by AI. Please review the change before merging.
This commit fixes the style issues introduced in 2988b14 according to the output
from Gofumpt and Prettier.

Details: #213
@sonarqubecloud
Copy link
Copy Markdown

@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Apr 18, 2026

DeepSource Code Review

We reviewed changes in da43d0b...4e8d13c on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Go Apr 18, 2026 1:58a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.57%. Comparing base (da43d0b) to head (4e8d13c).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   82.57%   82.57%           
=======================================
  Files           7        7           
  Lines         350      350           
=======================================
  Hits          289      289           
  Misses         49       49           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugoh hugoh merged commit cc8ef9f into main Apr 18, 2026
31 checks passed
@hugoh hugoh deleted the deepsource-autofix-0ea61d13 branch April 18, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant