-
Notifications
You must be signed in to change notification settings - Fork 273
fix: parse subscriptionOffers for iOS subscription products #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
96efa55
fix: parse subscriptionOffers for iOS subscription products
hyochan d04a0d7
refactor: remove redundant switch cases in subscription offers parsing
hyochan 265b4f3
docs: add 8.2.7 release blog post
hyochan 8b6099d
fix: use safe numeric parsing for subscription offers
hyochan b89ead2
fix: use _toInt for period value parsing
hyochan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| --- | ||
| slug: 8.2.7 | ||
| title: "8.2.7 - iOS subscriptionOffers Fix" | ||
| authors: [hyochan] | ||
| tags: [release, bug-fix] | ||
| --- | ||
|
|
||
| # 8.2.7 | ||
|
|
||
| This release fixes a bug where `subscriptionOffers` was always null on iOS subscription products. | ||
|
|
||
| ## Bug Fixes | ||
|
|
||
| ### subscriptionOffers Parsing for iOS | ||
|
|
||
| Previously, `ProductSubscriptionIOS.subscriptionOffers` was always null even though the native OpenIAP layer returned the data correctly. This has been fixed by adding proper parsing logic in the Dart layer. | ||
|
|
||
| ```dart | ||
| final subscriptions = await iap.fetchProducts<ProductSubscription>( | ||
| skus: ['premium_monthly'], | ||
| type: ProductQueryType.Subs, | ||
| ); | ||
|
|
||
| for (final sub in subscriptions) { | ||
| if (sub is ProductSubscriptionIOS) { | ||
| // Now correctly populated | ||
| final offers = sub.subscriptionOffers; | ||
| if (offers != null) { | ||
| for (final offer in offers) { | ||
| print('Offer: ${offer.id}'); | ||
| print('Type: ${offer.type}'); // introductory, promotional | ||
| print('Payment Mode: ${offer.paymentMode}'); // freeTrial, payAsYouGo, etc. | ||
| print('Price: ${offer.displayPrice}'); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| ## Installation | ||
|
|
||
| ```yaml | ||
| dependencies: | ||
| flutter_inapp_purchase: ^8.2.7 | ||
| ``` | ||
|
|
||
| ## Related | ||
|
|
||
| - [Issue #616](https://github.com/hyochan/flutter_inapp_purchase/issues/616) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.