Skip to content

fix: map PlatformException to proper ErrorCode in all methods #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyochan merged 4 commits into from
Feb 27, 2026
Merged

fix: map PlatformException to proper ErrorCode in all methods #621

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90dff9c
fix: map PlatformException to proper ErrorCode in all methods
hyochan Feb 26, 2026
57bafb7
fix: address review and improve test coverage
hyochan Feb 27, 2026
a926c05
test: add purchase_helpers tests and codecov guidance
hyochan Feb 27, 2026
2559cd9
docs: fix markdown lint in CLAUDE.md codecov section
hyochan Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 89 additions & 20 deletions lib/flutter_inapp_purchase.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,11 @@ class FlutterInappPurchase with RequestPurchaseBuilderApi {
await _channel.invokeMethod('initConnection', config);
_isInitialized = true;
return true;
} on PlatformException catch (error) {
throw _purchaseErrorFromPlatformException(
error,
'initialize IAP connection',
);
} catch (error) {
throw PurchaseError(
code: gentype.ErrorCode.NotPrepared,
Expand All @@ -265,6 +270,11 @@ class FlutterInappPurchase with RequestPurchaseBuilderApi {

_isInitialized = false;
return true;
} on PlatformException catch (error) {
throw _purchaseErrorFromPlatformException(
error,
'end IAP connection',
);
} catch (error) {
throw PurchaseError(
code: gentype.ErrorCode.ServiceError,
Expand Down Expand Up @@ -466,10 +476,13 @@ class FlutterInappPurchase with RequestPurchaseBuilderApi {
code: gentype.ErrorCode.IapNotAvailable,
message: 'requestPurchase is not supported on this platform',
);
} on PlatformException catch (error) {
throw _purchaseErrorFromPlatformException(
error,
'request purchase',
);
} catch (error) {
if (error is PurchaseError) {
rethrow;
}
if (error is PurchaseError) rethrow;
throw PurchaseError(
code: gentype.ErrorCode.ServiceError,
message: 'Failed to request purchase: ${error.toString()}',
Expand Down Expand Up @@ -568,7 +581,13 @@ class FlutterInappPurchase with RequestPurchaseBuilderApi {
}

return await resolvePurchases();
} on PlatformException catch (error) {
throw _purchaseErrorFromPlatformException(
error,
'get available purchases',
);
} catch (error) {
if (error is PurchaseError) rethrow;
throw PurchaseError(
code: gentype.ErrorCode.ServiceError,
message: 'Failed to get available purchases: ${error.toString()}',
Expand All @@ -587,10 +606,12 @@ class FlutterInappPurchase with RequestPurchaseBuilderApi {
'getStorefront',
);
return storefront ?? '';
} catch (error) {
debugPrint(
'[getStorefront] Failed to get storefront on ${_platform.operatingSystem}: $error',
} on PlatformException catch (error) {
throw _purchaseErrorFromPlatformException(
error,
'get storefront',
);
} catch (error) {
throw PurchaseError(
code: gentype.ErrorCode.ServiceError,
message: 'Failed to get storefront: ${error.toString()}',
Expand Down Expand Up @@ -618,10 +639,13 @@ class FlutterInappPurchase with RequestPurchaseBuilderApi {
code: gentype.ErrorCode.ServiceError,
message: 'Failed to get storefront country code',
);
} on PlatformException catch (error) {
throw _purchaseErrorFromPlatformException(
error,
'get storefront',
);
} catch (error) {
if (error is PurchaseError) {
rethrow;
}
if (error is PurchaseError) rethrow;
throw PurchaseError(
code: gentype.ErrorCode.ServiceError,
message: 'Failed to get storefront: ${error.toString()}',
Expand Down Expand Up @@ -832,11 +856,17 @@ class FlutterInappPurchase with RequestPurchaseBuilderApi {
try {
await channel.invokeMethod('presentCodeRedemptionSheetIOS');
return true;
} on PlatformException catch (error) {
throw _purchaseErrorFromPlatformException(
error,
'present code redemption sheet',
);
} catch (error) {
if (error is PurchaseError) rethrow;
throw PurchaseError(
code: gentype.ErrorCode.ServiceError,
message:
'Failed to present code redemption sheet: ${error.toString()}',
message: 'Failed to present code redemption sheet: '
'${error.toString()}',
);
}
};
Expand All @@ -854,11 +884,17 @@ class FlutterInappPurchase with RequestPurchaseBuilderApi {
try {
await channel.invokeMethod('showManageSubscriptionsIOS');
return const <gentype.PurchaseIOS>[];
} on PlatformException catch (error) {
throw _purchaseErrorFromPlatformException(
error,
'show manage subscriptions',
);
} catch (error) {
if (error is PurchaseError) rethrow;
throw PurchaseError(
code: gentype.ErrorCode.ServiceError,
message:
'Failed to show manage subscriptions: ${error.toString()}',
message: 'Failed to show manage subscriptions: '
'${error.toString()}',
);
}
};
Expand Down Expand Up @@ -1619,7 +1655,13 @@ class FlutterInappPurchase with RequestPurchaseBuilderApi {
);
return inApps;
}
} on PlatformException catch (error) {
throw _purchaseErrorFromPlatformException(
error,
'fetch products',
);
} catch (error) {
if (error is PurchaseError) rethrow;
throw PurchaseError(
code: gentype.ErrorCode.ServiceError,
message: 'Failed to fetch products: ${error.toString()}',
Expand Down Expand Up @@ -1676,6 +1718,24 @@ class FlutterInappPurchase with RequestPurchaseBuilderApi {
}
};

/// Convert a PlatformException to a PurchaseError with proper error code
PurchaseError _purchaseErrorFromPlatformException(
PlatformException error,
String operation,
) {
final errorCode = errors.ErrorCodeUtils.fromPlatformCode(
error.code,
_platform.isIOS || _platform.isMacOS
? gentype.IapPlatform.IOS
: gentype.IapPlatform.Android,
);
return PurchaseError(
code: errorCode,
message: 'Failed to $operation [${error.code}]: '
'${error.message ?? error.details}',
);
}

/// Recursively convert platform channel Map/List to proper Dart types
dynamic _deepConvertMap(dynamic value) {
if (value is Map) {
Expand Down Expand Up @@ -1768,12 +1828,17 @@ class FlutterInappPurchase with RequestPurchaseBuilderApi {

return _parseActiveSubscriptions(result);
} catch (error) {
if (error is PurchaseError) {
rethrow;
if (error is PurchaseError) rethrow;
if (error is PlatformException) {
throw _purchaseErrorFromPlatformException(
error,
'get active subscriptions',
);
}
throw PurchaseError(
code: gentype.ErrorCode.ServiceError,
message: 'Failed to get active subscriptions: ${error.toString()}',
message: 'Failed to get active subscriptions: '
'${error.toString()}',
);
}
};
Expand Down Expand Up @@ -2024,13 +2089,17 @@ class FlutterInappPurchase with RequestPurchaseBuilderApi {
'isEligibleForExternalPurchaseCustomLinkIOS',
);
return result ?? false;
} on PlatformException catch (error) {
throw _purchaseErrorFromPlatformException(
error,
'check eligibility for ExternalPurchaseCustomLink',
);
} catch (error) {
debugPrint(
'isEligibleForExternalPurchaseCustomLinkIOS error: $error');
if (error is PurchaseError) rethrow;
throw PurchaseError(
code: gentype.ErrorCode.ServiceError,
message:
'Failed to check eligibility for ExternalPurchaseCustomLink: $error',
message: 'Failed to check eligibility for '
'ExternalPurchaseCustomLink: $error',
);
}
};
Expand Down
Loading
⚡