fix(android): return file:// URIs for recording and support file:// in playback#703
fix(android): return file:// URIs for recording and support file:// in playback#703
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @hyochan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request standardizes the handling of file paths for audio recording and playback on Android. It ensures that recording operations consistently return file:// URIs, and that the playback mechanism can properly consume these URIs, improving consistency and compatibility within the audio module.
Highlights
- Android Audio Recording Output: The start and stop recording methods on Android now consistently return file:// URIs instead of raw file paths, aligning with standard URI conventions.
- Android Audio Playback Input: The audio playback functionality on Android has been enhanced to correctly interpret and handle file:// URIs, ensuring seamless playback from such paths.
- Dependency Update: The NitroAudioRecorderPlayer dependency in the example project's Podfile.lock has been updated from version 4.4.1 to 4.4.2 to reflect these changes.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the Android implementation to consistently use file:// URIs when returning paths from startRecorder and stopRecorder, and adds support for playing back from file:// URIs. The changes in startRecorder and stopRecorder are well-implemented, including improved error handling in stopRecorder. However, the implementation for handling file:// URIs in startPlayer is fragile and can be improved for robustness, as detailed in my comment.
android/src/main/java/com/margelo/nitro/audiorecorderplayer/AudioRecorderPlayer.kt
Show resolved
Hide resolved
…tency - Use Uri.fromFile() for proper file URI generation - Handle file:// URIs correctly in startPlayer using Uri.parse() - Improve error handling in stopRecorder to reject promise when path unavailable - Fixes #693
|
@brianlenz Will ship this to |
|
Works great, thanks again, @hyochan! |
2 participants
Return file:// URIs on start/stop; handle file:// playback.