Return error if multiple brackets exist in the authority#445
Merged
seanmonstar merged 2 commits intohyperium:masterfrom Dec 8, 2020
aeryz:fix-authority-parse
Merged
Return error if multiple brackets exist in the authority#445seanmonstar merged 2 commits intohyperium:masterfrom aeryz:fix-authority-parse
seanmonstar merged 2 commits intohyperium:masterfrom
aeryz:fix-authority-parse
Conversation
seanmonstar
reviewed
Dec 8, 2020
Member
seanmonstar
left a comment
seanmonstar
left a comment
There was a problem hiding this comment.
This looks good to me, it'd be good to add the unit tests the value that was triggering the panic.
Contributor
Author
|
I added a test which tests the exact string that causes the bug. |
|
Thanks! |
Merged
BenxiangGe
pushed a commit
to BenxiangGe/http
that referenced
this pull request
Jul 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #435