Skip to content

Add String and &String convert for PathAndQuery#450

Merged
seanmonstar merged 1 commit intohyperium:masterfrom
mkindahl:into_path_and_query
Dec 8, 2020
Merged

Add String and &String convert for PathAndQuery#450
seanmonstar merged 1 commit intohyperium:masterfrom
mkindahl:into_path_and_query

Conversation

@mkindahl
Copy link
Copy Markdown
Contributor

@mkindahl mkindahl commented Dec 1, 2020

When building a URI, it is not possible to provide neither String nor
&String, which is useful when adding a path_and_query from a string
built using format!.

This commit adds implementation of From and From<&String> for
PathAndQuery.

When building a URI, it is not possible to provide neither String nor
&String, which is useful when adding a path_and_query from a string
built using format!.

This commit adds implementation of From<String> and From<&String> for
PathAndQuery.
@mkindahl
Copy link
Copy Markdown
Contributor Author

mkindahl commented Dec 1, 2020

Unsure about the procedure for contributing a patch. Please advise.

Copy link
Copy Markdown
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@seanmonstar seanmonstar merged commit 8be5a58 into hyperium:master Dec 8, 2020
@dekellum dekellum mentioned this pull request Dec 14, 2020
@mkindahl mkindahl deleted the into_path_and_query branch December 15, 2020 11:37
BenxiangGe pushed a commit to BenxiangGe/http that referenced this pull request Jul 26, 2021
When building a URI, it is not possible to provide neither String nor
&String, which is useful when adding a path_and_query from a string
built using format!.

This commit adds implementation of From<String> and From<&String> for
PathAndQuery.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants