fix(tonic): Expose h2 error instead of reason#883
Merged
LucioFranco merged 1 commit intohyperium:masterfrom Jan 12, 2022
Merged
fix(tonic): Expose h2 error instead of reason#883LucioFranco merged 1 commit intohyperium:masterfrom
LucioFranco merged 1 commit intohyperium:masterfrom
Conversation
Member
|
iirc I think this change makes sense but its probably a breaking change since source downcasts will have to change. |
LucioFranco
approved these changes
Jan 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when an error occurs at the H2 layer, it is transformed into a
tonic::Statuswith asource()containing only the H2 error reason, instead of the full error. This loses a ton of context, as it is now impossible to know if the failure was caused by a protocol error, a general IO error (and if so, what what IO error), or something else entirely. It makes it much harder to debug problems.It is unclear why this choice was made in #612. There's talk about
Cloneimplementations causing this to be necessary, but I can't find that implementation.Solution
This MR simply bubbles up the underlying
h2::Error.tonic::Status::sourcewill contain anh2::Errorinstead of anh2::Reason.