feat(health): Expose HealthService publically#930
Merged
LucioFranco merged 4 commits intohyperium:masterfrom Mar 18, 2022
Merged
feat(health): Expose HealthService publically#930LucioFranco merged 4 commits intohyperium:masterfrom
HealthService publically#930LucioFranco merged 4 commits intohyperium:masterfrom
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Contributor
Author
|
cc @LucioFranco |
Member
|
@tisonkun looks like there is a CI failure? |
LucioFranco
changed the title
HealthService publically
Contributor
Author
|
@LucioFranco 2c0da18 is the fix.. |
Contributor
Author
|
@LucioFranco I think this PR is ready to merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tison wander4096@gmail.com
This closes #929.
I'm glad to add some tests, but the existing
NAMEdoesn't have tests and I don't have idea where to add some.