Update the data model reference to the latest iroha dev revision#485
Merged
DCNick3 merged 4 commits intohyperledger-iroha:mainfrom May 15, 2024
Merged
Update the data model reference to the latest iroha dev revision#485DCNick3 merged 4 commits intohyperledger-iroha:mainfrom
DCNick3 merged 4 commits intohyperledger-iroha:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
98e21e0 to
9d7004f
Compare
9d7004f to
752aaa0
Compare
Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>
…g paths Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>
752aaa0 to
48643e4
Compare
…4544 Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>
Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>
Contributor
Author
|
As CI was failing due to broken links to |
0x009922
approved these changes
May 15, 2024
Contributor
I think it's totally fine. Thank you for updating schema generation too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does three things:
While the inclusion of toml templates in place of old json files makes the config documentation "wrong", this allows writing new documentation with references to a more up-to-date
schema.json.In the end I think the #397 will in the end remove the toml templates altogether, I consider this just a way to unblock my updates to the torii reference for hyperledger-iroha/iroha#4544
@0x009922 Do you think it's a good approach? Or should we try somehow to keep the old
json's in place while the new config reference is not yet complete?