Open
Conversation
Signed-off-by: Stukalov-A-M <stukalov07@gmail.com>
Stukalov-A-M
force-pushed
the
block_stream
branch
from
618a8f6 to
22d6e10
Compare
WRRicht3r
approved these changes
Nov 27, 2023
0x009922
reviewed
Dec 4, 2023
Contributor
0x009922
left a comment
0x009922
left a comment
There was a problem hiding this comment.
Good start. Please don't perceive my comments as very critical. I understand that you are new to Rust and the code is totally fine.
Rust/examples/block_stream.rs
Outdated
Comment on lines
+27
to
+30
| fn initiate_block_listener( | ||
| iroha_client: &Client, | ||
| initial_block_number: u64, | ||
| ) -> Result<(), Box<dyn Error>> { |
Contributor
There was a problem hiding this comment.
For example readability, I'd move it into main directly.
0x009922
reviewed
Dec 4, 2023
| let iroha_client: Client = Client::new(&config).unwrap(); | ||
|
|
||
| /// Processing the initial block number to a non zero value | ||
| let block_number = NonZeroU64::new(1).expect("The block number most be > 0"); |
Contributor
There was a problem hiding this comment.
I think the message in expect(..), in this case, would better say something like "it will never fail, because 1 > 0".
0x009922
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.