[suggestion] Simplify genesis config

[0x009922]

Description

I propose to simplify genesis configuration a little bit by moving it to config file & env and dropping the related CLI flag.

How it works now

There are the following configurations:

• --submit-genesis CLI flag to enable submitting for a particular field
• IROHA_GENESIS env var with path to genesis file (defaults to genesis.json)
• genesis.public_key (GENESIS_PUBLIC_KEY) parameter that must be set for ALL peers
• genesis.private_key (GENESIS_PRIVATE_KEY) parameter that must be set when --submit-genesis is set.

What is wrong:

• IROHA_GENESIS can only be set via ENV
• Intention to submit genesis is duplicated by setting --submit-genesis and genesis.private_key

Proposed change

• genesis.public_key, required for all
• genesis.private_key and genesis.file for the peer that submits the genesis
• genesis.file might have a default value (genesis.json) which is applied if only genesis.private_key is set. Although it might make behaviour somewhat unclear. I think enforcing genesis.file to be set explicitly will be more reliable.

Benefits:

• Flexible: genesis might be configured via only config file, or via only ENV, or mixed
• Simple: no extra CLI flag

[6r1d]

Thanks, that looks reasonable. If this issue is copied to the docs with minimal changes, it will help the users a lot in the setup stage.

[0x009922]

Related discussion: hyperledger-iroha/iroha-2-docs#397 (comment)

[Mingela]

What is the error handling procedure in case multiple peers have genesis private key specified?

[0x009922]

What is the error handling procedure in case multiple peers have genesis private key specified?

@Mingela, I don't know how the situation of multiple peers submitting genesis blocks is handled now. Anyway, this proposal doesn't change anything here. It only changes the way of configuration.

[Mingela]

Fine to me then

[mversic]

I would like to preserve the explicit intent to submit genesis. This way user would not get into a situation where multiple nodes submit genesis accidentally. If multiple nodes submitting genesis is not an issue, then we can take the behavior as describe in this issue