Skip to content

fix select version protoc for install #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tock-ibm merged 1 commit into from
Dec 2, 2025
+1 −1
Merged

fix select version protoc for install #655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

env:
GO_VER: 1.25.3
PROTOC_VER: 33.0
PROTOC_VER: "33.0"
Copy link
Copy Markdown
Contributor

@tock-ibm tock-ibm Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pfi79 why is it a problem? is in interpreted as a number instead of a version?

Copy link
Copy Markdown
Contributor Author

@pfi79 pfi79 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the robot tried to throw a pr that failed validation. The installation of protocol 33.0 is specified, but action installed 33.1. For some reason they missed a significant 0. The quotation marks made it so that action would not skip this zero.

here is an example of a version change error
image

Copy link
Copy Markdown
Contributor Author

@pfi79 pfi79 Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to fix this situation, and then I'll restart the robot pipes.

PROTOC_GEN_GO_VER: v1.36.10

jobs:
Expand Down
⚡