adjust hyara to work in BN plugin manager, PySide 6 support#18
Merged
hyuunnn merged 1 commit intohyuunnn:masterfrom Jun 15, 2022
Merged
adjust hyara to work in BN plugin manager, PySide 6 support#18hyuunnn merged 1 commit intohyuunnn:masterfrom
hyuunnn merged 1 commit intohyuunnn:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only thing left is to create the tag and release (I've already updated the version in the readme and the new
plugin.jsonrequired for the plugin manager. This PR:__init__.pyto not auto-load cutter if cutter is not available.Oh, if you happen to ever remake the introduction GIF it would be great if it started on BN first because our plugin manager doesn't support animated gifs and it's a bit awkward that the first frame shows IDA. 🤣 Of course, Lighthouse has the same issue.
Once you accept the PR and create the release, I'll add it to the official plugin manager and it will look like this for everyone!
A few other long-term notes while I'm at it:
bvinstead of the DockWidget method, I'll try to remember to PR that later.global area,panel, orviewwidgets, but that is also a more substantial change for another time.This PR resolves #9.