View git_diff() between two specific commits

[fin-w]

Does git_diff() only accept ref ? That what the below seems to imply:

---@class fzf-lua.config.GitDiff: fzf-lua.config.GitBase
---@field ref? string

I feel it would be more useful to continue by default diffing against HEAD (I think that's what it's doing?) but optionally accept two commit hashes.

I've tried to hack it but the check for a valid commit hash doesn't accept this as I'm trying to send two commits hashes in the place of one:

        commits = {
            actions = {
                ['alt-v'] = {
                    fn = function(selected, opts)
                        -- Copy the commit hash of the selected entry into a register,
                        -- then open the diff of the commit vs the parent commit
                        require('fzf-lua').actions.git_yank_commit(selected, opts)
                        local git_commit_to_show = vim.fn.getreg('*')
                        local git_commit_previous = git_commit_to_show .. "^"
                        require('fzf-lua').git_diff({ ref = git_commit_previous .. " " .. git_commit_to_show })
                    end
                },
            }
      }

All I want to achieve to to view the specific commit I'm looking at with git_commits() in the git_diff() picker, for better context than the git_commits() previewer provides. And the diff to show should be the difference between the previous commit and the commit I have selected in git_diff().

Is this possible? If not, can I prepare a MR to add { parent = "", ref = "" } as the arguments git_diff() ?

[ibhagwan]

I’m sure it’s possible it’s a good use case, you’d probably need to modify the previewer too, if you wanna PR this you’re most welcome.