Bug: trouble.sources.fzf.actions.open_all fails

[sfarina]

RTFM Checklist

• I have searched exisiting issues / discussions
• I have read the Wiki including the Advanced section
• I have read man fzf / I am well versed in shell fzf

Operating system

Mac os

Shell

fish

Neovim version (nvim --version)

NVIM v0.11.2

Fzf version (fzf --version)

0.64.0 (brew)

Output of :lua print(os.getenv('FZF_DEFAULT_OPTS'))

--no-multi

Is the problem reproducible with mini.sh?

• My issue is reproducible with mini.sh
• My issue IS NOT reproducible with mini.sh
• I have not tested with mini.sh (not relevant, requires LSP, Windows, etc)

Fzf-lua configuration

as lazy plugin

{ -- fzf: fuzzy finder. use for finding all manner of things.
    "ibhagwan/fzf-lua",
    enabled = true,
    lazy = false,
    dependencies = { "nvim-tree/nvim-web-devicons" },
    keys = {
      { "<leader>e", "<cmd> FzfLua files<CR>", desc = "find: fzf files" },
      { "<leader>f/", "<cmd> FzfLua live_grep<CR>", desc = "find: live grep" },
      { "<leader>f#", "<cmd> FzfLua grep_cword<CR>", desc = "find: cursor" },
      { "<leader>f&", "<cmd> FzfLua grep<CR>", desc = "find: filtered grep" },
      { "<leader>fm", "<cmd> FzfLua <CR>", desc = "find: meta - search pickers" },
      { "<leader>ff", "<cmd> FzfLua files<CR>", desc = "find: fzf files" },
      { "<leader>fg", "<cmd> FzfLua git_files<CR>", desc = "find: git files" },
      { "<leader>fk", "<cmd> FzfLua lsp_references<CR>", desc = "find: lsp references" },
      { "<leader>f?", "<cmd> FzfLua search_history<CR>", desc = "find: previous searches" },
      { "<leader>fp", "<cmd> FzfLua registers<CR>", desc = "find: Paste from available registers" },
      { "<leader>fb", "<cmd> FzfLua buffers<CR>", desc = "find: buffers" },
      { "<leader>f.", "<cmd> FzfLua resume<CR>", desc = "find: resume" },
    },
    config = function()
      local conf = require("fzf-lua.config")
      local actions = require("trouble.sources.fzf").actions
      conf.defaults.actions.files["ctrl-x"] = actions.open_all

      require("fzf-lua").setup{
        files = {
          fd_opts = [[--color=never --type f --type l --exclude '*.pyc' --exclude .git --no-ignore-vcs]],
          },
        }
    end,
  }

Describe the bug / steps to reproduce

regression:
trying to open search results with trouble fails with

[Fzf-lua] fn_selected threw an error: ...share/nvim/lazy/trouble.nvim/lua/trouble/sources/fzf.lua:82: attempt to index field '__INFO' (a nil value)
stack traceback:
	.../.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/core.lua:262: in function <.../.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/core.lua:247>

steps:
open fzf-lua search
press ctrl-x (as per my keybinding above)
fail

[sfarina]

this is maybe actually a bug with trouble's plugin looking for a field that no longer exists (__INFO)

[ibhagwan]

This is most likely related to the recent refactors, folke being away I might have to create a back compat patch.

[dpetka2001]

I get a similar error to this about the same field

[Fzf-lua] fn_selected threw an error: ...m/lazy/LazyVim/lua/lazyvim/plugins/extras/editor/fzf.lua:72: attempt to index field '__INFO' (a nil value)
stack traceback:
.../.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/core.lua:262: in function <...erto/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/core.lua:247>

and is due to this part of config here, line 72 where __INFO tries to get accessed.

Any idea about a workaround?

[nenahp]

FzfLua.get_info() ?

[ibhagwan]

FzfLua.get_info() ?

That would work but nobody can update the code while the maintainer is away, I'll create a workaround tomorrow.

[dpetka2001]

FzfLua.get_info() ?

Thanks for your suggestion. I applied this in my personal configuration and it solves the issue indeed. I will mention it to users who have the same problem and Folke can update the code when he gets back eventually.

[dpetka2001]

Actually FzfLua.get_info() will not work. It doesn't contain the cmd from when invoking :FzfLua files or :FzfLua live_grep. The previous __INFO.cmd would contain files or live_grep depending on which subcommand you invoked FzfLua with. Is this information somewhere else available?

[ibhagwan]

86e3ba8

@dpetka2001, should work now, lmk if otherwise?

[sfarina]

It works for me.

Probably something for folke, but now I get a warning from trouble, probably because of my nvim-treesitter configs...

nvim-treesitter parser missing `text`

[sfarina]

also, thank you for fixing this so quickly!

[dpetka2001]

@ibhagwan Yes, works like a charm. Thank you!! 😄

Probably in the context I was using it inside the action, get_info() was not returning all relevant fields from picker.