Bug: Invalid window id on lsp_references

[mikehaertl]

RTFM Checklist

• I have searched exisiting issues / discussions
• I have read the Wiki including the Advanced section
• I have read man fzf / I am well versed in shell fzf

Operating system

Linux Mint

Shell

bash

Neovim version (nvim --version)

NVIM v0.11.3

Fzf version (fzf --version)

0.62.0

Output of :lua print(os.getenv('FZF_DEFAULT_OPTS'))

--color fg:7,bg:0,hl:13,fg+:2,bg+:6,hl+:13 --color query:13,info:12,prompt:13,spinner:3,marker:9 --cycle --bind=change:first,ctrl-n:page-down,ctrl-p:page-up,ctrl-t:toggle-preview,ctrl-alt-j:preview-down,ctrl-alt-k:preview-up,ctrl-alt-n:preview-page-down,ctrl-alt-p:preview-page-up,tab:accept,ctrl-o:toggle+d own,ctrl-alt-a:toggle-all

Is the problem reproducible with mini.sh?

• My issue is reproducible with mini.sh
• My issue IS NOT reproducible with mini.sh
• I have not tested with mini.sh (not relevant, requires LSP, Windows, etc)

Fzf-lua configuration

local actions = require "fzf-lua.actions"
local fzflua = require('fzf-lua')
fzflua.setup({
  'fzf-native',
  winopts = {
    backdrop = false,
    split = "botright new",
    preview = {
      horizontal = 'right:50%',
    },
  },
  actions = {
    files = {
      -- providers that inherit these actions:
      --   files, git_files, git_status, grep, lsp
      --   oldfiles, quickfix, loclist, tags, btags, args
      ["default"]     = actions.file_edit,
      ["ctrl-x"]      = actions.file_split,
      ["ctrl-v"]      = actions.file_vsplit,
      ["alt-q"]       = actions.file_sel_to_qf,
      ["alt-l"]       = actions.file_sel_to_ll,
    },
    buffers = {
      -- providers that inherit these actions:
      --   buffers, tabs, lines, blines
      ["default"]     = actions.buf_edit,
      ["ctrl-x"]      = actions.buf_split,
      ["ctrl-v"]      = actions.buf_vsplit,
    }
  },
  fzf_colors = {
      ['fg']          = { 'fg', 'Normal' },
      ['bg']          = { 'bg', 'Normal' },
      ['hl']          = { 'fg', 'Green' },
      ['fg+']         = { 'fg', 'CursorLine' },
      ['bg+']         = { 'bg', 'CursorLine' },
      ['hl+']         = { 'fg', 'Green' },
      ['info']        = { 'fg', 'Yellow' },
      ['prompt']      = { 'fg', 'Red' },
      ['pointer']     = { 'fg', 'Blue' },
      ['marker']      = { 'fg', 'Blue' },
      ['spinner']     = { 'fg', 'Yellow' },
      ['header']      = { 'fg', 'Blue' },
      ['gutter']      = { 'bg', 'Normal' },
  },
  -- providers
  buffers = {
    filename_only = true,
    winopts = {
      split = "topleft new",
    },
    actions = {
      -- actions inherit from 'actions.buffers'
      -- by supplying a table of functions we're telling
      -- fzf-lua to not close the fzf window
      -- can resume the buffers picker on the same window
      -- eliminating an otherwise unaesthetic win "flash"
      ["ctrl-q"]      = { fn = actions.buf_del, reload = true },
      -- override plugin default mapping
      ["ctrl-x"]      = actions.buf_split,
    }
  },
  files = {
    path_shorten = false,
  },
  git = {
    status = {
      preview_pager = 'delta --width=$FZF_PREVIEW_COLUMNS',
    },
    commits = {
      preview_pager = 'DELTA_FEATURES=+ delta --width=$FZF_PREVIEW_COLUMNS',
    },
    bcommits = {
      preview_pager = 'delta --width=$FZF_PREVIEW_COLUMNS',
      actions = {
        ['ctrl-x'] = actions.git_buf_split,
      }
    },
  },
  grep = {
    path_shorten = true,
    winopts = {
      split = false,
      fullscreen = true,
    },
  },
  highlights = {
    winopts = {
      split = false,
      fullscreen = true,
    },
  },
  lsp = {
    -- use async calls instead of sync + timeout
    async_or_timeout = true,
    symbols = {
      winopts = {
        split = false,
        fullscreen = true,
      },
    },
  },
  oldfiles = {
    cwd_only = true,
    winopts = {
      preview = { hidden = "hidden" },
    },
  },
})

fzflua.register_ui_select()

Describe the bug / steps to reproduce

When I use :FzfLua lsp_references and there are not results I get this error:

Error executing vim.schedule lua callback: .../.local/share/nvim/plugged/fzf-lua/lua/fzf-lua/shell.lua:439: ...ke/.local/share/nvim/plugged/fzf-lua/lua/fzf-lua/win.lua:346: Invalid window id: 1004
stack traceback:
[C]: in function 'error'
.../.local/share/nvim/plugged/fzf-lua/lua/fzf-lua/shell.lua:439: in function 'fn'
.../.local/share/nvim/plugged/fzf-lua/lua/fzf-lua/shell.lua:143: in function <.../.local/share/nvim/plugged/fzf-lua/lua/fzf-lua/shell.lua:142>

For example if I try to find references for this method:

fzf-lua/lua/fzf-lua/init.lua

Lines 322 to 324 in 71fe5c1

	function M.hide()
	return M.win.hide()
	end

Using git bisect I found the error was introduced with this commit: 0efda21.

[ibhagwan]

Can you update to the latest commit in Fzf-lua? It’s hard for me to make sense from the stack trace as line win.lua:346 doesn’t lead anywhere that should trigger this error.

[mikehaertl]

I'm on f579824 now. Here's the error again:

Error executing vim.schedule lua callback: .../.local/share/nvim/plugged/fzf-lua/lua/fzf-lua/shell.lua:441: ...ke/.local/share/nvim/plugged/fzf-lua/lua/fzf-lua/win.lua:352: Invalid window id: 1005
stack traceback:
[C]: in function 'error'
.../.local/share/nvim/plugged/fzf-lua/lua/fzf-lua/shell.lua:441: in function 'fn'
.../.local/share/nvim/plugged/fzf-lua/lua/fzf-lua/shell.lua:143: in function <.../.local/share/nvim/plugged/fzf-lua/lua/fzf-lua/shell.lua:142>

[nenahp]

I meet the same issue when toggle-preview after resume

[nenahp]

blame to this line

fzf-lua/lua/fzf-lua/win.lua

Line 1474 in de1ddf7

self:SIGWINCH()

[ibhagwan]

13513d6

@nenahp, this solves the preview toggle and hopefully also the issue OP is describing as I couldn't reproduce it.

@mikehaertl, can you test if the latest commit solves your issue?

[nenahp]

No still error:
EDIT: i'm wrong, fixed, seems not update

coroutine.wrap(function()
  local co = coroutine.running()
  local wait = function(ms)
    vim.defer_fn(function() coroutine.resume(co) end, ms or 1000)
    coroutine.yield()
  end
  require('fzf-lua').commands({
    winopts = { split = 'botright new', preview = { horizontal = 'right:50%' } },
  })
  wait()
  vim.api.nvim_feedkeys(vim.keycode('<c-c>'), 'n', false)
  wait()
  require('fzf-lua').resume()
  wait()
  require('fzf-lua').win.toggle_preview()
  wait()
  require('fzf-lua').win.toggle_preview()
end)()

[nenahp]

sorry, actually fixed

[ibhagwan]

sorry, actually fixed

Thanks, we’ll wait for @mikehaertl to confirm if this fixes the OP issue as well.

[mikehaertl]

Yes, seems to be fixed now. Thank you!