refactor: always setlocal on window options

[phanen]

• refactor: always setlocal on window options
  • chore: remove useless autocmd
  • refactor: move logic to win:resized, win:save_size
  • refactor: simplify utils.eventignore
• fix(previewer): prefer winopts.winhl (useful with non-float window as previewer)

[ibhagwan]

Since this was added in 0.10 and we still support 0.9 don’t we still need vim.fn.exists("&winfixbuf") == 1?

[phanen]

i change the semantic of utils.wo
see in tests/utils_spec

[phanen]

i write something wrong right vim.wo in eq should be utils.wo

[ibhagwan]

i write something wrong right vim.wo in eq should be utils.wo

But it is utils.wo

[ibhagwan]

Same as other comment, wasn’t eventignorewin only added with 0.10?

[staticssleever668]

After commit 05a4af9, preview windows have different background until the window is resized.
This is reproducible with https://raw.githubusercontent.com/ibhagwan/fzf-lua/main/scripts/mini.sh.
I'm on NVIM v0.11.3.

[ibhagwan]

#2266

[phanen]

Resume this line seems work? idk why

diff --git a/lua/fzf-lua/win.lua b/lua/fzf-lua/win.lua
index c6957ce..5462533 100644
--- a/lua/fzf-lua/win.lua
+++ b/lua/fzf-lua/win.lua
@@ -531,7 +531,8 @@ function FzfWin:reset_win_highlights(win)
       end
     end
   end
-  utils.wo[win].winhl = hl
+  -- utils.wo[win].winhl = hl
+  if vim.wo[win].winhighlight ~= hl then vim.wo[win].winhighlight = hl end
 end
 
 ---@param exit_code integer

[ibhagwan]

5d2ba91

@phanen, not sure why nvim_set_option_value exhibits this behavior, try it with:

:hi! link FzfLuaPreviewNormal IncSearch
:FzfLua files

[ibhagwan]

Resume this line seems work? idk why

I'm confused too, but isn't vim.wo[winid] equals to nvim_set_option_value with scope=local?

[phanen]

isn't vim.wo[winid] equals to nvim_set_option_value with scope=local?

no it‘s scope=nil

[ibhagwan]

isn't vim.wo[winid] equals to nvim_set_option_value with scope=local?

no it‘s scope=nil

I see, we can leave it like this until we figure out what’s wrong, as long as there’s no downside

[phanen]

til
i misunderstand what setlocal does
neovim/neovim#24397 (comment)