Skip to content

fix(actions): werid issue when set verbose=1#2680

Merged
phanen merged 1 commit intomainfrom
werid-verbose-1-issue
Apr 18, 2026
Merged

fix(actions): werid issue when set verbose=1#2680
phanen merged 1 commit intomainfrom
werid-verbose-1-issue

Conversation

@phanen
Copy link
Copy Markdown
Collaborator

@phanen phanen commented Apr 17, 2026

Maybe there're other similar issue, to be discovered

Fix #2679

Summary by CodeRabbit

  • Bug Fixes
    • More reliable jump-to-location behavior on Neovim 0.11+ to reduce noisy output and improve navigation.
    • Improved stability on Windows by adding short delays to reduce race conditions during rapid file/preview operations.
    • Consistent previewer resize behavior on Windows to prevent flaky layout changes during interactive resizing.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 86cacec2-4ad7-42cc-aff9-8415644ee1a6

📥 Commits

Reviewing files that changed from the base of the PR and between 3332b2e and 20130fd.

📒 Files selected for processing (2)
  • lua/fzf-lua/utils.lua
  • tests/win_spec.lua
✅ Files skipped from review due to trivial changes (1)
  • lua/fzf-lua/utils.lua
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/win_spec.lua

📝 Walkthrough

Walkthrough

For Neovim >= 0.11, M.jump_to_location now calls vim.lsp.util.show_document(...) wrapped in M.with({ o = { verbose = 0 } }, ...). Tests in tests/win_spec.lua adjust callback args, compress a resize handler, add Windows-only skips for toggle-preview, and introduce a short Windows-only sleep in an __after_open hook.

Changes

Cohort / File(s) Summary
LSP Jump Location Update
lua/fzf-lua/utils.lua
For Neovim >= 0.11, M.jump_to_location wraps vim.lsp.util.show_document(location, offset_encoding, { reuse_win = reuse_win, focus = true }) with M.with({ o = { verbose = 0 } }, function() ... end) and returns the wrapped call's result.
Windows Test Adjustments
tests/win_spec.lua
Test callback parameter renamed to action; removed a per-invocation builtin lookup; added helpers.SKIP_IF_WIN() when action == "toggle-preview" in the "start", "load", "result" loop; compressed keymap.fzf.resize handler into one line; added a Windows-only vim.uv.sleep(250) in the __after_open hook before awaiting _previewer.last_entry.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇 I quiet the shout, tuck noise away,
wrap a jump so it softly plays.
On Windows I pause a little beat,
nudge tests to finish, tidy and neat. 🥕

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning Test changes in win_spec.lua modify unrelated Windows CI behavior and toggle-preview handling, which extends beyond fixing the LSP file_tabedit issue. Move test modifications to a separate PR focused on Windows CI stability or revert them if they address different issues than #2679.
Title check ❓ Inconclusive The title mentions 'verbose=1' but changes wrap show_document with verbose=0 to suppress output, addressing the actual fix needed for LSP entries. Clarify title to be more specific: consider 'fix(actions): suppress verbose output when showing LSP documents' to better reflect the actual code change.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The core change wraps show_document with verbose=0 to fix file_tabedit with LSP entries, directly addressing issue #2679's requirement.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch werid-verbose-1-issue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lua/fzf-lua/utils.lua`:
- Around line 1628-1631: The closure passed to M.with in M.jump_to_location
drops the return value of vim.lsp.util.show_document causing the function to
return nil; update the inner closure to return
vim.lsp.util.show_document(location, offset_encoding, { reuse_win = reuse_win,
focus = true }) so the result (boolean) is propagated consistently with the else
branch and the `@return` annotation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f313e4ee-1511-4030-8eeb-617c38c683a6

📥 Commits

Reviewing files that changed from the base of the PR and between 83f7195 and e0eeb2f.

📒 Files selected for processing (1)
  • lua/fzf-lua/utils.lua

Comment thread lua/fzf-lua/utils.lua
@ibhagwan
Copy link
Copy Markdown
Owner

Windows CI is so annoying it has become worse lately, I hate this “solution” but considering skipping more tests on Windows, such a horrible OS

@phanen
Copy link
Copy Markdown
Collaborator Author

phanen commented Apr 18, 2026

Not sure if this is a real bug.

parametrize = vim.iter(require("fzf-lua.defaults").defaults.keymap.builtin)

This table is a random order, and each time ci failure will happened on toggle-preview

@phanen
Copy link
Copy Markdown
Collaborator Author

phanen commented Apr 18, 2026

but in any way the child/channel instance should not die

@phanen phanen force-pushed the werid-verbose-1-issue branch 2 times, most recently from 1380d7c to 3332b2e Compare April 18, 2026 07:41
maybe there're other similar issue, to be discovered

ci: skip flaky windows test
@phanen phanen force-pushed the werid-verbose-1-issue branch from 3332b2e to 20130fd Compare April 18, 2026 07:47
@phanen phanen merged commit 76535c3 into main Apr 18, 2026
11 checks passed
@phanen phanen deleted the werid-verbose-1-issue branch April 18, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: file_tabedit don't work with lsp entry

2 participants