fix(actions): werid issue when set verbose=1#2680
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughFor Neovim >= 0.11, Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@lua/fzf-lua/utils.lua`:
- Around line 1628-1631: The closure passed to M.with in M.jump_to_location
drops the return value of vim.lsp.util.show_document causing the function to
return nil; update the inner closure to return
vim.lsp.util.show_document(location, offset_encoding, { reuse_win = reuse_win,
focus = true }) so the result (boolean) is propagated consistently with the else
branch and the `@return` annotation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
Windows CI is so annoying it has become worse lately, I hate this “solution” but considering skipping more tests on Windows, such a horrible OS |
|
Not sure if this is a real bug. Line 150 in 77cfef6 This table is a random order, and each time ci failure will happened on toggle-preview |
|
but in any way the child/channel instance should not die |
1380d7c to
3332b2e
Compare
maybe there're other similar issue, to be discovered ci: skip flaky windows test
3332b2e to
20130fd
Compare
Maybe there're other similar issue, to be discovered
Fix #2679
Summary by CodeRabbit