Skip to content

fix(previewer): only highlight helptags on label#2689

Merged
phanen merged 1 commit intomainfrom
vim-regex
Apr 20, 2026
Merged

fix(previewer): only highlight helptags on label#2689
phanen merged 1 commit intomainfrom
vim-regex

Conversation

@phanen
Copy link
Copy Markdown
Collaborator

@phanen phanen commented Apr 20, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed formatting of help tag entries in previewer results to display correctly.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 188d236d-de0e-4fe9-a4a1-5a7516a9ad85

📥 Commits

Reviewing files that changed from the base of the PR and between 3da04a9 and fe6621f.

📒 Files selected for processing (1)
  • lua/fzf-lua/previewer/builtin.lua

📝 Walkthrough

Walkthrough

The ctag value returned by Previewer.help_tags:parse_entry was reformatted to wrap the tag in [[*%s*]] markup. This changes the output format of the help tags previewer's internal IIFE function.

Changes

Cohort / File(s) Summary
Help Tags Previewer
lua/fzf-lua/previewer/builtin.lua
Modified the ctag return value in parse_entry to use formatted string [[*%s*]] instead of returning tag directly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • #2687: Adds logic to check entry.ctag in set_cursor_hl control flow, which directly depends on the format of the ctag value modified by this change.

Poem

🐰 A tag wrapped in asterisks bright,
Now formatted just right,
[[*%s*]] holds the way,
The help text looks better today! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: applying highlighting formatting specifically to the help tag label in the previewer, which aligns with the code modification of wrapping the tag value in a formatted string.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch vim-regex

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@phanen phanen merged commit fcabe3c into main Apr 20, 2026
11 checks passed
@phanen phanen deleted the vim-regex branch April 21, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant