Skip to content

fix(previewer): set i keymap only for normal mode#2705

Merged
ibhagwan merged 1 commit intoibhagwan:mainfrom
PeterCardenas:only-map-normal-for-i-keymap
Apr 26, 2026
Merged

fix(previewer): set i keymap only for normal mode#2705
ibhagwan merged 1 commit intoibhagwan:mainfrom
PeterCardenas:only-map-normal-for-i-keymap

Conversation

@PeterCardenas
Copy link
Copy Markdown
Contributor

@PeterCardenas PeterCardenas commented Apr 26, 2026

Allows for keymaps like yip to work. Previously it would focus the prompt terminal window

Summary by CodeRabbit

  • Bug Fixes
    • Fixed keymap functionality in the preview window to work correctly in normal mode.

Allows for keymaps like `vip` to work
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 06566d47-0b67-4857-a4e7-ba070fa55f70

📥 Commits

Reviewing files that changed from the base of the PR and between 1ae863c and 07b6647.

📒 Files selected for processing (1)
  • lua/fzf-lua/previewer/builtin.lua

📝 Walkthrough

Walkthrough

A keymap in the preview buffer is updated to explicitly register for normal mode ("n") instead of an unspecified mode. The mapping behavior and functionality remain unchanged.

Changes

Cohort / File(s) Summary
Preview Buffer Keymap
lua/fzf-lua/previewer/builtin.lua
Updated keymap mode specification from unspecified/empty to normal mode ("n") in Previewer.base:set_preview_buf.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A mode that was hiding, now plain to see,
Normal mode keymap, as clear as can be!
One tiny change brings clarity bright,
The preview buffer now mapped just right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: specifying normal mode for the 'i' keymap in the previewer, which aligns with the PR's core objective of fixing keymap scope.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ibhagwan
Copy link
Copy Markdown
Owner

Ty @PeterCardenas

@ibhagwan ibhagwan merged commit 33321eb into ibhagwan:main Apr 26, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants