Overview
Combining --keep-icloud-recent-days with a filtering option like --skip-videos results in the filtered files being deleted even though they weren't downloaded.
Steps to Reproduce
In a library containing videos run icloudpd with --keep-icloud-recent-days 0 --skip-videos
Expected Behavior
None of the videos are downloaded or deleted in iCloud.
Actual Behavior
None of the videos are downloaded but all are deleted in iCloud.
Context
Problem appears to be lines #1421 - #1434 in base.py. The legacy delete_after_download check is only done if download_photo() returns True (lines #1418 - #1419). But the keep_icloud_recent_days check is executed unconditionally.
Overview
Combining --keep-icloud-recent-days with a filtering option like --skip-videos results in the filtered files being deleted even though they weren't downloaded.
Steps to Reproduce
In a library containing videos run icloudpd with --keep-icloud-recent-days 0 --skip-videos
Expected Behavior
None of the videos are downloaded or deleted in iCloud.
Actual Behavior
None of the videos are downloaded but all are deleted in iCloud.
Context
Problem appears to be lines #1421 - #1434 in base.py. The legacy delete_after_download check is only done if download_photo() returns True (lines #1418 - #1419). But the keep_icloud_recent_days check is executed unconditionally.