Check more carefully for 'isFavorite' since it's not always there#1060
Merged
AndreyNikiforov merged 1 commit intoicloud-photos-downloader:masterfrom Jan 18, 2025
Merged
Conversation
Fixes icloud-photos-downloader#1058, see that issue for an example of a file where this would throw an exception before.
euank
force-pushed
the
isFavoriteCheck
branch
from
d3c23d0 to
b7ce1f7
Compare
rhoopr
referenced
this pull request
in rhoopr/kei
Feb 8, 2026
…58 (#1060) Fixes #1058, see that issue for an example of a file where this would throw an exception before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1058, see that issue for an example of a file where this would throw an exception before.
I've added a unit test which errored before this change as well.