Setting timeout for HTTP: requests does not hanging forever if the download speed is zero (addressing an issue when Apple does not response to HTTP GET)#1114
Conversation
|
seems that symptoms this PR fixes better match #793 WDYT? |
|
Yes, it might be. If we decide to merge: I would add it as config parameter for the session (so I would extend the commit a bit). |
Oh, you mean so it applies to all requests to Apple? Sounds good. Can you think of any tests? Validating that timing out request is properly handled seems nice, but probably unrealistic to check all places. May be you can figure out how to test for original symptom (stuck requests)? |
|
Taking a look over the weekend. |
naszta
force-pushed
the
bugfix/timeout
branch
5 times, most recently
from
58373da to
6f2ad28
Compare
|
I added a similar test we have for |
|
Are we cool? |
Update changelog pls. The code seems fine. |
…ownload speed is zero (addressing an issue when Apple does not response to HTTP GET)
|
Done. |
AndreyNikiforov
merged commit 5fac423
into
icloud-photos-downloader:master
…nload speed is zero (addressing an issue when Apple does not response to HTTP GET) (#1114)
2 participants
Addressing issue #787 .