Refactor dependency injection functional composition#1236

Merged

AndreyNikiforov merged 14 commits intoicloud-photos-downloader:masterfrom

AndreyNikiforov:refactor/dependency-injection-functional-composition

Aug 30, 2025

Commits on Aug 30, 2025

refactor: make AssetVersion immutable by moving filename disambiguation to caller

AndreyNikiforov
and
claude
committed
refactor: extract calculate_version_filename into static function

AndreyNikiforov
and
claude
committed
refactor: remove lp_filename_generator dependency from PhotosService

AndreyNikiforov
and
claude
committed
refactor: remove lp_filename_generator from PyiCloudService completely

AndreyNikiforov
and
claude
committed
refactor: restore keep_unicode_in_filenames functionality with clean architecture

AndreyNikiforov
and
claude
committed
refactor: remove file_match_policy parameter from PyiCloudService

AndreyNikiforov
and
claude
committed
refactor: extract file_match_policy logic from calculate_filename into separate function

AndreyNikiforov
and
claude
committed
refactor: extract filename_cleaner logic from calculate_filename into separate function

AndreyNikiforov
and
claude
committed
Extract fingerprint hash logic from calculate_filename() into separate fallback function

AndreyNikiforov
and
claude
committed
Extract raw_policy from PyiCloudService using dependency injection pattern

AndreyNikiforov
and
claude
committed
Implement fromMaybe function and replace bind_filename_with_fallback with functional composition

AndreyNikiforov
and
claude
committed
refactor: use base Session class instead of PyiCloudSession in PhotoAsset.download

AndreyNikiforov
and
claude
committed
refactor: extract service dependencies from PhotoLibrary and PhotoAlbum constructors

AndreyNikiforov
and
claude
committed
docs: add comprehensive refactoring context documentation

AndreyNikiforov
and
claude
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor dependency injection functional composition#1236

Refactor dependency injection functional composition#1236
AndreyNikiforov merged 14 commits intoicloud-photos-downloader:masterfrom
AndreyNikiforov:refactor/dependency-injection-functional-composition

Commits on Aug 30, 2025

refactor: make AssetVersion immutable by moving filename disambiguation to caller

refactor: extract calculate_version_filename into static function

refactor: remove lp_filename_generator dependency from PhotosService

refactor: remove lp_filename_generator from PyiCloudService completely

refactor: restore keep_unicode_in_filenames functionality with clean architecture

refactor: remove file_match_policy parameter from PyiCloudService

refactor: extract file_match_policy logic from calculate_filename into separate function

refactor: extract filename_cleaner logic from calculate_filename into separate function

Extract fingerprint hash logic from calculate_filename() into separate fallback function

Extract raw_policy from PyiCloudService using dependency injection pattern

Implement fromMaybe function and replace bind_filename_with_fallback with functional composition

refactor: use base Session class instead of PyiCloudSession in PhotoAsset.download

refactor: extract service dependencies from PhotoLibrary and PhotoAlbum constructors

docs: add comprehensive refactoring context documentation