Fix authentication content node dumping#1241
Merged
AndreyNikiforov merged 2 commits intoicloud-photos-downloader:masterfrom Sep 1, 2025
Merged
Conversation
Previously, response_body() incorrectly used response.raw.stream which is not a valid attribute, causing content to be skipped for authentication requests and other non-streaming responses that needed content capture. Changes: - Add is_streaming_response() function using response.raw.isclosed() - Update response_body() to properly detect streaming vs non-streaming - Add comprehensive tests with local HTTP server - Verify JSON/text responses include content in HAR entries - Verify streaming responses skip content to prevent memory leaks - Test with multi-GB streams to ensure no memory consumption This fixes authentication request logging where content was missing from HAR entries, improving debugging capabilities for auth issues. Related to icloud-photos-downloader#1240 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add entry for the HTTP response content capture fix that ensures authentication requests and other non-streaming responses properly include their content in HAR entries for improved debugging. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
AndreyNikiforov
merged commit 278a035
into
icloud-photos-downloader:master
398 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.