Skip to content

fix: parse trusted phone numbers from bridgeInitiateData #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Li-Huakang wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −2
Open

fix: parse trusted phone numbers from bridgeInitiateData #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- fix: parse SMS trusted phone numbers from Apple's `bridgeInitiateData` payload

## 1.32.2 (2025-09-01)

- fix: HTTP response content not captured for authentication and non-streaming requests [#1240](https://github.com/icloud-photos-downloader/icloud_photos_downloader/issues/1240)
Expand Down
5 changes: 3 additions & 2 deletions src/pyicloud_ipd/sms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,10 @@ def parse_trusted_phone_numbers_payload(content: str) -> Sequence[TrustedDevice]
parser = _SMSParser()
parser.feed(content)
parser.close()
two_sv = parser.sms_data.get("direct", {}).get("twoSV", {})
numbers: Sequence[Mapping[str, Any]] = (
parser.sms_data.get("direct", {})
.get("twoSV", {})
two_sv.get("phoneNumberVerification", {}).get("trustedPhoneNumbers", [])
or two_sv.get("bridgeInitiateData", {})
.get("phoneNumberVerification", {})
.get("trustedPhoneNumbers", [])
)
Expand Down
7 changes: 7 additions & 0 deletions tests/test_authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,13 @@ def test_parse_trusted_phone_numbers_payload_minimal(self) -> None:
self.assertEqual(1, len(result), "number of numbers parsed")
self.assertEqual(expected, result[0], "parsed number")

def test_parse_trusted_phone_numbers_payload_bridge_initiate_data(self) -> None:
html = '<script type="application/json" class="boot_args">{"direct":{"twoSV":{"bridgeInitiateData":{"phoneNumberVerification":{"trustedPhoneNumbers":[{"numberWithDialCode":"+1 (•••) •••-••81","pushMode":"sms","obfuscatedNumber":"(•••) •••-••81","lastTwoDigits":"81","id":1}]}},"authInitialRoute":"auth/verify/phone"}}}</script>' # noqa: E501
expected = _TrustedDevice(id=1, obfuscated_number="(***) ***-**81")
result = parse_trusted_phone_numbers_payload(html)
self.assertEqual(1, len(result), "number of numbers parsed")
self.assertEqual(expected, result[0], "parsed number")

def test_parse_trusted_phone_numbers_payload_missing_node0(self) -> None:
html = '<script type="application/json" class="boot_args">{"MISSINGdirect":{"twoSV":{"phoneNumberVerification":{"trustedPhoneNumbers":[{"numberWithDialCode":"+1 (•••) •••-••81","pushMode":"sms","obfuscatedNumber":"(•••) •••-••81","lastTwoDigits":"81","id":1}]},"authInitialRoute":"auth/verify/phone"}}}</script>' # noqa: E501
result = parse_trusted_phone_numbers_payload(html)
Expand Down
⚡