support to delete downloaded photos#525
support to delete downloaded photos#525ddnm102 wants to merge 19 commits intoicloud-photos-downloader:masterfrom
Conversation
change delete list to 20 items
|
@ryda20 thanks a lot for contribution. Quick question: what happens if user specifies existing |
AndreyNikiforov
left a comment
AndreyNikiforov
left a comment
There was a problem hiding this comment.
Please rebase to get tests working, add tests for new functionality, and suggest idea to prevent total loss of photo assets (locally and in the cloud).
| deletes any files found in there. (If you | ||
| restore the photo in iCloud, it will be | ||
| downloaded again.) | ||
| --auto-delete-downloaded Auto delete downloaded photo from icloud. |
There was a problem hiding this comment.
What can we do to help users avoid running --auto-delete-downloaded and --auto-delete together or consequently (which will delete all photos locally and in the cloud)?
|
|
||
|
|
||
| photos_delete_list = [] | ||
| def auto_delete_downloaded_photos(photo, end=False): |
There was a problem hiding this comment.
Can we have a test for this new functionality, please?
|
There is similar feature in #431 . What are the differences between the two? |
2 participants
Hi there!
Thank you so much for spending time to write this tool!!
In my case, I need to delete all photos from iCloud after downloaded to save space for next sync from my iPhone (free plan only have 5GG), so, after searching and testing, I already added "--auto-delete-downloaded" flag.
I think, it is not only my needed case, someone else will need. So, Please kindly take a look if you want to add this feature!
Thank you so much!