Closed
Conversation
Collaborator
Author
|
There is another question here on how to best explain the underscore case for all those places where we explain referencing of keys, which is at least 3 places in the readme. See #148 for why… |
tordans
changed the title
namename
matkoniecz
reviewed
Jan 6, 2026
| Upon merging into the `main` branch, this is sent to Transifex for translating to other localizations. Changing the name of an existing preset will require it to be re-translated to all localizations. | ||
|
|
||
| A preset can optionally reference the label of another by using that preset's name contained in brackets, like `{preset}`. In which case the presets's _terms_ and _aliases_ are also automatically sourced from that other field. This is for example useful for regional presets which should get the same labels as the preset they are based on. | ||
| A preset can optionally reference the name of another by using that preset's name in brackets, like `{folder/preset}`. In which case the presets's _terms_ and _aliases_ are also automatically sourced from that other field. This is for example useful for regional presets which should get the same labels as the preset they are based on. |
Contributor
There was a problem hiding this comment.
Suggested change
| A preset can optionally reference the name of another by using that preset's name in brackets, like `{folder/preset}`. In which case the presets's _terms_ and _aliases_ are also automatically sourced from that other field. This is for example useful for regional presets which should get the same labels as the preset they are based on. | |
| A preset can optionally reference the identifier of another by using that preset's name in brackets, like `{folder/preset}`. In which case the presets's _terms_ and _aliases_ are also automatically sourced from that other field. This is for example useful for regional presets which should get the same labels as the preset they are based on. |
they are not referencing their name, from what I see
For example https://github.com/openstreetmap/id-tagging-schema/blob/5c85ba0b277f21739a58629aa29e2cea802dc655/data/presets/shop/art.json would be referenced by shop/art - not by Art Store
maybe "location" would also work?
matkoniecz
added a commit
to matkoniecz/schema-builder
that referenced
this pull request
Jan 6, 2026
For example https://github.com/openstreetmap/id-tagging-schema/blob/5c85ba0b277f21739a58629aa29e2cea802dc655/data/presets/shop/art.json would be referenced by `shop/art` - not by `Art Store` maybe "identifier" would also work? this is alternative to and closes ideditor#149
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this wording should be like in this PR, right?
However, I am not sure if this whole part is actually true. does adding a reference for the
namereally mean that alsotermsandaliasesare copied? Is there a way around this, like addingterms(or an empty array) in the present itself?Or could it be that one has to reference the preset for each of those keys separately?