Skip to content

consider other unicode commas when splitting translated terms#228

Merged
tyrasd merged 1 commit intomainfrom
kh/other-commas
Jan 6, 2026
Merged

consider other unicode commas when splitting translated terms#228
tyrasd merged 1 commit intomainfrom
kh/other-commas

Conversation

@k-yle
Copy link
Copy Markdown
Collaborator

@k-yle k-yle commented Aug 19, 2025

Closes openstreetmap/id-tagging-schema#472. Independent of #227

Translators with other keyboard layouts might use delimeters other than the basic latin comma (,).

For example the arabic comma (،), CJK list comma (), and possibly others that I'm not familiar with.

Comment thread lib/translations.js Outdated
@matkoniecz
Copy link
Copy Markdown
Contributor

I guess that demanding translators (unlike from say programmers) use unusual to them commas is not the best idea and this would be fine?

@matkoniecz
Copy link
Copy Markdown
Contributor

Just to confirm: have you tested it?

@k-yle
Copy link
Copy Markdown
Collaborator Author

k-yle commented Oct 31, 2025

I guess that demanding translators (unlike from say programmers) use unusual to them commas is not the best idea and this would be fine?

perhaps we should discuss the merits of this idea at openstreetmap/id-tagging-schema#472 where other people have previously commented

Just to confirm: have you tested it?

Yes, but unfortunately the weird repo setup means that there is no way to showcase that PRs in this repo work correctly. Even a hack like this will still fail the CI

Copy link
Copy Markdown
Collaborator

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked transifex, and it is still an issue that the "wrong" comma is used for the list of search terms. Let's allow it for the sake of easier convenience of contributing translations.

@tyrasd tyrasd merged commit d7e456d into main Jan 6, 2026
2 checks passed
@k-yle k-yle deleted the kh/other-commas branch January 6, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Farsi translation uses arabic commas in 'terms'

3 participants